-
Notifications
You must be signed in to change notification settings - Fork 74
Feature/thermodynamic integration #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thomasloux
wants to merge
12
commits into
TorchSim:main
Choose a base branch
from
thomasloux:feature/thermodynamic_integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/thermodynamic integration #263
thomasloux
wants to merge
12
commits into
TorchSim:main
from
thomasloux:feature/thermodynamic_integration
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for this contribution! Convert out of draft when you want a review, happy to take a look. |
Collaborator
Author
|
I have some incoming commits that needs Velocity / Cell rescaling to be implemented. Waiting for #326 to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding a big feature to compute free energy for crystal phases.
Reference:
Reference:
"Adiabatic switching applied to realistic crystalline solids: Vacancy-formation
free energy in copper." Physical Review B 55.2 (1997): 735.
Inspiration and sources:
"Nonequilibrium free-energy calculation of solids using LAMMPS."
Computational Materials Science 112 (2016): 333-341.
Note: I need to add the pipeline to see the results for different simulation lengths, for different temperatures and the actual evaluation to find the temperature of transition of titanium from HCP to BCC. I try to reproduce https://calorine.materialsmodeling.org/get_started/free_energy_tutorial.html
The code is a somewhat direct application of LAMMPS implementation.
What is lacking?
What can evolve?
Checklist
Before a pull request can be merged, the following items must be checked:
We highly recommended installing the pre-commit hooks running in CI locally to speedup the development process. Simply run
pip install pre-commit && pre-commit installto install the hooks which will check your code before each commit.