Handling "one session with only one process"#5
Open
noahcui wants to merge 6 commits intoToniWestbrook:masterfrom
Open
Handling "one session with only one process"#5noahcui wants to merge 6 commits intoToniWestbrook:masterfrom
noahcui wants to merge 6 commits intoToniWestbrook:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the original code, get_session_chains only removes items from expand_remain when a child process of the current session is found (line 370, which is inside the for loop starting at line 355).
However, there is a potential case where a session contains only a single process and does not spawn any child processes. In such cases, the corresponding process in expand_remain is never discarded.
Since the while True loop (starting at line 384) only exits when expand_current becomes empty—which never happens in this case—this results in an infinite loop.
My solution: Add logic to discard processes from expand_remain if they are not expandable (i.e., they have no children), to ensure the loop can eventually terminate.