Skip to content

Conversation

@TheJoeFin
Copy link
Owner

No description provided.

Base automatically changed from dev to main February 24, 2025 01:44
@TheJoeFin TheJoeFin requested a review from Copilot May 31, 2025 19:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to manage Windows OCR language settings by updating UI bindings, introducing an Admin window for language installation, and enhancing utility methods with modern C# collection expressions. Key changes include:

  • Refactoring XAML bindings for improved readability.
  • Adding a new Admin window (and its associated XAML and code-behind) to install and load Windows OCR languages.
  • Integrating modern C# array/collection literal syntax in language utility methods and language settings.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Text-Grab/Views/GrabFrame.xaml Reformatted binding expressions to span multiple lines for clarity.
Text-Grab/Views/AdminWindow.xaml.cs New admin window logic for installing Windows OCR language packs using Dism API.
Text-Grab/Views/AdminWindow.xaml New UI view for the Admin window enabling language management.
Text-Grab/Utilities/WindowsLanguageUtilities.cs Introduced methods for generating PowerShell and DISM commands using the new array literal syntax.
Text-Grab/Text-Grab.csproj Added Microsoft.Dism package dependency.
Text-Grab/Pages/LanguageSettings.xaml.cs Updated binding initialization using modern collection expression and added a new admin event.
Text-Grab/Pages/LanguageSettings.xaml Added a new button to launch the Windows OCR language management functionality.
Text-Grab/App.xaml.cs Added a check for running the Admin window instance and launching it based on arguments.
Comments suppressed due to low confidence (2)

Text-Grab/Views/AdminWindow.xaml.cs:40

  • [nitpick] The method name 'InstalWindowsLangButton_Click' appears to be misspelled. Consider renaming it to 'InstallWindowsLangButton_Click' for clarity and consistency.
private async void InstalWindowsLangButton_Click(object sender, RoutedEventArgs e)

Text-Grab/Pages/LanguageSettings.xaml.cs:156

  • [nitpick] The method name 'InstalWindowsLangButton_Click' may be unintentionally misspelled. For clarity, consider updating it to 'InstallWindowsLangButton_Click'.
private void InstalWindowsLangButton_Click(object sender, RoutedEventArgs e)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants