Picking refactoring from GeoView to OpenSmock.

[LabordePierre]

Start global refactoring to OpenSmock.
Works only with:

• Refactor picking in several traits, uses by D/GShapes + start layered views refactoring OpenSmock/OpenSmock#107

[Nyan11]

In this example:

exampleCirclesHover
	| geoView layer circle |
	geoView := GeoViewElement new.
	layer := GeoViewDShapesLayer new name: #shapes.
	geoView addLayer: layer.

        "Circle to add to the geoview"
	circle := (SmockDCircle key: #circle)
		          coordinates:
			          (geoView mapProjection projLatLonToCart:
					           AbsoluteCoordinates zero);
		          radius: 1000000;
		          strokeColor: Color green;
		          strokeWidth: 5.
	layer addDShape: circle.
	geoView addObject: circle.

        "My event"
	geoView addEventHandler: (BlEventHandler
			 on: BlPrimaryClickEvent
			 do: [ :evt |
					 | elements |
					 elements := geoView pickAt: evt position radius: 10.
					 elements results do: [ :each |
							 each dShape strokeColor: Color random.
							 geoView updateObject: each.
                                                         "Use the inspector to inspect the pick"
							 elements inspect ] ]).
	^ self openViewInWindow: geoView

When i click on 1 and change the zoom level: the circle change color.
When i click on 2 and change the zoom level: the circle do not change color.

I have 2 questions:

• How do i say to my geoView that it need to be updated (without needing to update the zoom level) ?
• Is this normal that the dShape has a radius of 1000000 but the associated gShapes only has a radius of 100 ?

[Nyan11]

For the review:

Better example

A simplier example than exampleCitiesHover would be nice.
Something simple, a circle when pressed or hovered that changed its color.

Remove the GeoViewPickingEvent

There is an event named GeoViewPickingEvent.
I found it very confusing.
This event is trigger by GeoViewInteractionsStrategy every time you try to select any (or zero) objects.
I would rename this event GeoCursorPressedEvent or GeoViewObjectSelectionPickingEvent

Fix the GeoViewLayerEvent

GeoViewLayerRemovedEvent and GeoViewLayerAddedEvent should herit GeoViewLayerEvent

[Nyan11]

I would change the methods #pickable: and #pickable with #isPickable and #isPickabe:.
With the prefix is i understand it is a boolean.

[Nyan11]

I think you should rename all the methods that contains the word pickingElement with the word pickedElement.
See:
https://www.wordreference.com/enfr/picking
https://www.wordreference.com/enfr/picked

pick = verbe
picking = nom
picked = adjectif

I am not an expert in english, so to verify.

[LabordePierre]

I would change the methods #pickable: and #pickable with #isPickable and #isPickabe:. With the prefix is i understand it is a boolean.

Yes! I will rename. This is on OpenSmock too.

[ELePors]

Why adding reference to smock in GeoView hierarchy ?

[LabordePierre]

This is on OpenSmock too.

You are right, I will deprecate old name.

[LabordePierre]

Why adding reference to smock in GeoView hierarchy ?

I don't understand your question xD