Skip to content

Conversation

@vbreuss
Copy link
Member

@vbreuss vbreuss commented Nov 21, 2025

This PR updates the Microsoft.NET.Test.Sdk package from version 17.14.0 to 18.0.1, addressing compatibility requirements for the newer SDK version by suppressing target framework support build errors in test projects.

  • Bumped Microsoft.NET.Test.Sdk from v17.14.0 to v18.0.1
  • Added SuppressTfmSupportBuildErrors property to prevent build errors related to target framework compatibility

@vbreuss vbreuss self-assigned this Nov 21, 2025
Copilot AI review requested due to automatic review settings November 21, 2025 07:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Microsoft.NET.Test.Sdk package from version 17.14.0 to 18.0.1, addressing compatibility requirements for the newer SDK version by suppressing target framework support build errors in test projects.

  • Bumped Microsoft.NET.Test.Sdk from v17.14.0 to v18.0.1
  • Added SuppressTfmSupportBuildErrors property to prevent build errors related to target framework compatibility

Reviewed Changes

Copilot reviewed 2 out of 6 changed files in this pull request and generated 1 comment.

File Description
Directory.Packages.props Updated Microsoft.NET.Test.Sdk package version to 18.0.1
tests/Directory.Build.props Added SuppressTfmSupportBuildErrors property to handle TFM compatibility issues with the new SDK version
Files not reviewed (4)
  • .idea/.idea.System.IO.Abstractions/.idea/copilot.data.migration.agent.xml: Language not supported
  • .idea/.idea.System.IO.Abstractions/.idea/copilot.data.migration.ask.xml: Language not supported
  • .idea/.idea.System.IO.Abstractions/.idea/copilot.data.migration.ask2agent.xml: Language not supported
  • .idea/.idea.System.IO.Abstractions/.idea/copilot.data.migration.edit.xml: Language not supported

@vbreuss vbreuss enabled auto-merge (squash) November 21, 2025 07:32
@github-actions
Copy link

github-actions bot commented Nov 21, 2025

Test Results

   23 files   -     8     23 suites   - 8   8s ⏱️ -6s
1 043 tests  -   108    922 ✅  -   228  121 💤 +120  0 ❌ ±0 
6 745 runs   - 4 312  6 024 ✅  - 4 194  721 💤  - 118  0 ❌ ±0 

Results for commit 88e1795. ± Comparison against base commit 9caf7a1.

This pull request removes 108 tests.
System.IO.Abstractions.TestingHelpers.Tests.MockDirectoryInfoTests ‑ MockDirectoryInfo_Exists("c:\\temp\\folder",True)
System.IO.Abstractions.TestingHelpers.Tests.MockDirectoryInfoTests ‑ MockDirectoryInfo_Exists("c:\\temp\\folder\\notExistant",False)
System.IO.Abstractions.TestingHelpers.Tests.MockDirectoryInfoTests ‑ MockDirectoryInfo_GetExtension_ShouldReturnEmptyString("c:\\temp")
System.IO.Abstractions.TestingHelpers.Tests.MockDirectoryInfoTests ‑ MockDirectoryInfo_GetExtension_ShouldReturnEmptyString("c:\\temp\\")
System.IO.Abstractions.TestingHelpers.Tests.MockDirectoryTests ‑ MockDirectory_EnumerateDirectories_ShouldReturnPathsPrefixedWithQueryPath("Folder","Folder\\SubFolder")
System.IO.Abstractions.TestingHelpers.Tests.MockDirectoryTests ‑ MockDirectory_EnumerateDirectories_ShouldReturnPathsPrefixedWithQueryPath("Folder\\","Folder\\SubFolder")
System.IO.Abstractions.TestingHelpers.Tests.MockDirectoryTests ‑ MockDirectory_EnumerateDirectories_ShouldReturnPathsPrefixedWithQueryPath("Folder\\..\\.\\Folder","Folder\\..\\.\\Folder\\SubFolder")
System.IO.Abstractions.TestingHelpers.Tests.MockDirectoryTests ‑ MockDirectory_Move_ShouldMoveDirectories("A:\\folder1\\","A:\\folder3\\","file.txt","folder2\\file2.txt")
System.IO.Abstractions.TestingHelpers.Tests.MockDirectoryTests ‑ MockDirectory_Move_ShouldMoveDirectories("A:\\folder1\\","a:\\folder3\\","file.txt","Folder2\\fiLe2.txt")
System.IO.Abstractions.TestingHelpers.Tests.MockDirectoryTests ‑ MockDirectory_Move_ShouldMoveDirectories("A:\\folder1\\","a:\\folder3\\","file.txt","Folder2\\file2.txt")
…
This pull request skips 120 tests.
System.IO.Abstractions.TestingHelpers.Tests.MockDirectoryGetAccessControlTests ‑ MockDirectory_GetAccessControl_ShouldReturnAccessControlOfDirectoryData
System.IO.Abstractions.TestingHelpers.Tests.MockDirectoryGetAccessControlTests ‑ MockDirectory_GetAccessControl_ShouldThrowArgumentExceptionIfPathContainsOnlyWhitespaces("   ")
System.IO.Abstractions.TestingHelpers.Tests.MockDirectoryGetAccessControlTests ‑ MockDirectory_GetAccessControl_ShouldThrowArgumentExceptionIfPathContainsOnlyWhitespaces(" ")
System.IO.Abstractions.TestingHelpers.Tests.MockDirectoryGetAccessControlTests ‑ MockDirectory_GetAccessControl_ShouldThrowDirectoryNotFoundExceptionIfDirectoryDoesNotExistInMockData
System.IO.Abstractions.TestingHelpers.Tests.MockDirectoryInfoAccessControlTests ‑ MockDirectoryInfo_GetAccessControl_ShouldReturnAccessControlOfDirectoryData
System.IO.Abstractions.TestingHelpers.Tests.MockDirectoryInfoAccessControlTests ‑ MockDirectoryInfo_SetAccessControl_ShouldSetAccessControlOfDirectoryData
System.IO.Abstractions.TestingHelpers.Tests.MockDirectoryInfoTests ‑ Directory_exists_after_creation_with_security
System.IO.Abstractions.TestingHelpers.Tests.MockDirectoryInfoTests ‑ MockDirectoryInfo_FullName_ShouldReturnNormalizedUNCPath("\\\\unc/folder\\\\foo","\\\\unc\\folder\\foo")
System.IO.Abstractions.TestingHelpers.Tests.MockDirectoryInfoTests ‑ MockDirectoryInfo_FullName_ShouldReturnNormalizedUNCPath("\\\\unc\\folder","\\\\unc\\folder")
System.IO.Abstractions.TestingHelpers.Tests.MockDirectoryInfoTests ‑ MockDirectoryInfo_FullName_ShouldReturnPathWithTrimmedTrailingSpaces("c:\\temp\\folder  ","c:\\temp\\folder")
…

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants