-
Notifications
You must be signed in to change notification settings - Fork 2
Add simplified two-lens notebook with Collins FFT and automatic ABCD computation #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
157
commits into
main
Choose a base branch
from
copilot/vscode-mlb1gtut-voi3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…give reasonable results.
…a dimension after vmap
…fer function yet, but it does not matter for now.
…ance. I need to find a way to non dimensionalise everything.
…ians sadly. The problem is just crazy.
…ration Co-authored-by: DavidLanders95 <6655619+DavidLanders95@users.noreply.github.com>
Co-authored-by: DavidLanders95 <6655619+DavidLanders95@users.noreply.github.com>
Co-authored-by: DavidLanders95 <6655619+DavidLanders95@users.noreply.github.com>
Co-authored-by: DavidLanders95 <6655619+DavidLanders95@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Simplify two lens notebook and implement forward model
Add simplified two-lens notebook with Collins FFT and automatic ABCD computation
Feb 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies two-lens optical system analysis by replacing manual ABCD matrix computation with automatic differentiation and adding Collins FFT diffraction modeling with Bayesian optimization.
Implementation
two_lenses_simplified.ipynb: Streamlined workflow (28KB vs 616KB original)Lens+Detectorcomponentssolve_model()with JAX autodiffH(f) = exp(-iπλ(B/A)(fx² + fy²))using extracted ABCD parametersjax.image.resizeGrid configuration:
Test suite:
test_two_lenses_simplified.pyvalidates all componentsExample Usage
Files Added
examples/lens_inversion/two_lenses_simplified.ipynbexamples/lens_inversion/test_two_lenses_simplified.pyexamples/lens_inversion/README_simplified.mdexamples/lens_inversion/IMPLEMENTATION_SUMMARY.mdOriginal prompt
Created from VS Code.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.