Skip to content

Conversation

@EmelieNyberg
Copy link

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your chatbot project! 🍪 Let's go over each part of your code for more specific feedback and suggestions.

HTML/CSS

  • Well-structured HTML and nicely styled with CSS ⭐

JavaScript

  • The code is broken into functions, which is an excellent practice. Functions like goodbyeMessage, handleConfirmationChoice, and createConfirmationButtons are modular ⭐ By just reading what they are named, I understand what they are doing, so kudos on good naming as well! Just a tiny thing - to be even more conforming, you could change the goodbyeMessage function to be called sayGoodbye or sendGoodbyeMessage (so that it's named in verb form as the other functions 😄)
  • Consider adding basic input validation before processing user input (e.g., checking if the input field is empty before handling a form submission).
  • Fun addition with sound 🔈

Clean Code

  • Remember that everything should be in English (comments in this case)
  • Remember to remove unused code
  • Some class names could be more descriptive. For example, monster-picture and monster-picture2 could be named more contextually based on their usage (e.g., cookie-monster-main).
  • Again - really good function names overall ⭐

Keep up the good work ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants