Skip to content

[Pipeline Fix] Dev to Stage #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sujata-m merged 3 commits into from
Feb 11, 2025
Merged

[Pipeline Fix] Dev to Stage #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02e8138
Fixed Issue-1704
sujata-m Feb 11, 2025
953eb6d
Fixed indentation
sujata-m Feb 11, 2025
b45e5fb
Merge pull request #33 from TaskarCenterAtUW/feature-1704
sujata-m Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 16 additions & 17 deletions .github/workflows/dev_workflow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,20 +21,19 @@
docker build -t ${{ secrets.REGISTRY_DOMAIN }}/${{ secrets.REGISTRY_REPO }}:${{ github.sha }} -t ${{ secrets.REGISTRY_DOMAIN }}/${{ secrets.REGISTRY_REPO }}:${{ github.ref_name == 'main' && 'prod' || github.ref_name }}${{ github.ref_name != 'main' && '-latest' || 'latest' }} .
docker push ${{ secrets.REGISTRY_DOMAIN }}/${{ secrets.REGISTRY_REPO }} --all-tags
# This is done as Container Instance
# Deploy:
# needs: Build
# environment:
# name: Development
# runs-on: ubuntu-latest
# steps:
# - name: Login to Azure
# uses: azure/login@v1
# with:
# creds: ${{ secrets.TDEI_CORE_AZURE_CREDS }}
# - name: Deploy to Dev
# uses: azure/webapps-deploy@v2
# with:
# app-name: ${{ secrets.AZURE_WEBAPP_NAME }}
# images: ${{ secrets.REGISTRY_DOMAIN }}/${{ secrets.REGISTRY_REPO }}:${{ github.sha }}


Deploy:
needs: Build
environment:
name: Development
runs-on: ubuntu-latest
steps:
- name: Login to Azure
uses: azure/login@v1

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'dev_workflow.yaml' step
Uses Step
Loading
uses 'azure/login' with ref 'v1', not a pinned commit hash
with:
creds: ${{ secrets.TDEI_CORE_AZURE_CREDS }}
- name: Deploy to Dev
uses: azure/webapps-deploy@v2

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'dev_workflow.yaml' step
Uses Step
Loading
uses 'azure/webapps-deploy' with ref 'v2', not a pinned commit hash
with:
app-name: ${{ secrets.AZURE_WEBAPP_NAME }}
images: ${{ secrets.REGISTRY_DOMAIN }}/${{ secrets.REGISTRY_REPO }}:${{ github.sha }}
Comment on lines +25 to +38

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions Job or Workflow does not set permissions

30 changes: 15 additions & 15 deletions .github/workflows/stage_workflow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,21 +21,21 @@
docker build -t ${{ secrets.REGISTRY_DOMAIN }}/${{ secrets.REGISTRY_REPO }}:${{ github.sha }} -t ${{ secrets.REGISTRY_DOMAIN }}/${{ secrets.REGISTRY_REPO }}:${{ github.ref_name == 'main' && 'prod' || github.ref_name }}${{ github.ref_name != 'main' && '-latest' || 'latest' }} .
docker push ${{ secrets.REGISTRY_DOMAIN }}/${{ secrets.REGISTRY_REPO }} --all-tags
# This is done as Container Instance
# Deploy:
# needs: Build
# environment:
# name: Stage
# runs-on: ubuntu-latest
# steps:
# - name: Login to Azure
# uses: azure/login@v1
# with:
# creds: ${{ secrets.TDEI_CORE_AZURE_CREDS }}
# - name: Deploy to Dev
# uses: azure/webapps-deploy@v2
# with:
# app-name: ${{ secrets.AZURE_WEBAPP_NAME }}
# images: ${{ secrets.REGISTRY_DOMAIN }}/${{ secrets.REGISTRY_REPO }}:${{ github.sha }}
Deploy:
needs: Build
environment:
name: Stage
runs-on: ubuntu-latest
steps:
- name: Login to Azure
uses: azure/login@v1

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'stage_workflow.yaml' step
Uses Step
Loading
uses 'azure/login' with ref 'v1', not a pinned commit hash
with:
creds: ${{ secrets.TDEI_CORE_AZURE_CREDS }}
- name: Deploy to Dev
uses: azure/webapps-deploy@v2

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'stage_workflow.yaml' step
Uses Step
Loading
uses 'azure/webapps-deploy' with ref 'v2', not a pinned commit hash
with:
app-name: ${{ secrets.AZURE_WEBAPP_NAME }}
images: ${{ secrets.REGISTRY_DOMAIN }}/${{ secrets.REGISTRY_REPO }}:${{ github.sha }}



Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions Job or Workflow does not set permissions
Loading