-
Notifications
You must be signed in to change notification settings - Fork 13
feat: Model to track node states and has_ended flag #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+73
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| from cloud_pipelines_backend import backend_types_sql as bts | ||
| from cloud_pipelines_backend.api_server_sql import ExecutionStatusSummary | ||
|
|
||
|
|
||
| class TestExecutionStatusSummary: | ||
| def test_initial_state(self): | ||
| summary = ExecutionStatusSummary() | ||
| assert summary.total_executions == 0 | ||
| assert summary.ended_executions == 0 | ||
| assert summary.has_ended is False | ||
|
|
||
| def test_accumulate_all_ended_statuses(self): | ||
| """Add each ended status with 2^i count for robust uniqueness.""" | ||
| summary = ExecutionStatusSummary() | ||
| ended_statuses = sorted(bts.CONTAINER_STATUSES_ENDED, key=lambda s: s.value) | ||
| expected_total = 0 | ||
| expected_ended = 0 | ||
| for i, status in enumerate(ended_statuses): | ||
| count = 2**i | ||
| summary.count_execution_status(status=status, count=count) | ||
| expected_total += count | ||
| expected_ended += count | ||
| assert summary.total_executions == expected_total | ||
| assert summary.ended_executions == expected_ended | ||
| assert summary.has_ended is True | ||
|
|
||
| def test_accumulate_all_in_progress_statuses(self): | ||
| """Add each in-progress status with 2^i count for robust uniqueness.""" | ||
| summary = ExecutionStatusSummary() | ||
| in_progress_statuses = sorted( | ||
| set(bts.ContainerExecutionStatus) - bts.CONTAINER_STATUSES_ENDED, | ||
| key=lambda s: s.value, | ||
| ) | ||
| expected_total = 0 | ||
| for i, status in enumerate(in_progress_statuses): | ||
| count = 2**i | ||
| summary.count_execution_status(status=status, count=count) | ||
| expected_total += count | ||
| assert summary.total_executions == expected_total | ||
| assert summary.ended_executions == 0 | ||
| assert summary.has_ended is False | ||
|
|
||
| def test_accumulate_all_statuses(self): | ||
| """Add every status with 2^i count. Summary math must be exact.""" | ||
| summary = ExecutionStatusSummary() | ||
| all_statuses = sorted(bts.ContainerExecutionStatus, key=lambda s: s.value) | ||
| expected_total = 0 | ||
| expected_ended = 0 | ||
| for i, status in enumerate(all_statuses): | ||
| count = 2**i | ||
| expected_total += count | ||
| if status in bts.CONTAINER_STATUSES_ENDED: | ||
| expected_ended += count | ||
| summary.count_execution_status(status=status, count=count) | ||
| assert summary.total_executions == expected_total | ||
| assert summary.ended_executions == expected_ended | ||
| assert summary.has_ended == (expected_ended == expected_total) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.