refactor: Use new flag in API to check pipeline run has ended#1823
Open
yuechao-qin wants to merge 1 commit intomasterfrom
Open
refactor: Use new flag in API to check pipeline run has ended#1823yuechao-qin wants to merge 1 commit intomasterfrom
yuechao-qin wants to merge 1 commit intomasterfrom
Conversation
camielvs
reviewed
Feb 20, 2026
Comment on lines
+42
to
+43
| const isComplete = state.summary.has_ended; | ||
| const isInProgress = !isComplete; |
Collaborator
There was a problem hiding this comment.
Does "complete" state include "failed" or "cancelled" states? if yes, then `isInProgress could be incorrect at times
Collaborator
Author
There was a problem hiding this comment.
It does include those states here.
Interesting, can you help me understand what isInProgress is suppose to mean then in the UI?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends On
This PR-99 must be landed before this can be merged.
Description
Using new flag
has_endedin API (GET /api/executions/{executionId}/state) to determine if a root execution node is completed.NOTE
has_endedflag is context aware of the children nodes' statuses under any root execution nodeType of Change
Checklist
Test Instructions
state) doesn't fetch anymore when run has endedsrc/utils/executionStatus.tsis latest in Chrome1.mov (uploaded via Graphite)
2.mov (uploaded via Graphite)