Skip to content

Comments

feat: Double-Click to Edit Flex Nodes in-place#1783

Merged
camielvs merged 1 commit intomasterfrom
02-10-feat_double-click_to_edit_flex_nodes_in-place
Feb 19, 2026
Merged

feat: Double-Click to Edit Flex Nodes in-place#1783
camielvs merged 1 commit intomasterfrom
02-10-feat_double-click_to_edit_flex_nodes_in-place

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Feb 10, 2026 •
edited
Loading

Description

Adds an inline text editor to Flex Nodes. This can be activated by double-clicking the node. This is used for the body content only. Title, colour and z-index editing must be done via the context panel.

Related Issue and Pull requests

Progresses https://github.com/Shopify/oasis-frontend/issues/118

Type of Change

  • New feature

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

image.png

Test Instructions

  • Place a sticky note on the canvas
  • Double click it
  • Confirm you are able to directly enter text into the body of the sticky note without having to go via the context panel
  • Deselect the sticky note and confirm your entered text has saved

Additional Comments

This was referenced Feb 10, 2026
Merged
Merged
Merged
@camielvs Graphite App
Copy link
Collaborator Author

camielvs commented Feb 10, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camielvs camielvs force-pushed the 02-09-feat_pack_flex_nodes_into_subgraphs branch from be4bdba to cc047fd Compare February 10, 2026 21:56
@camielvs camielvs force-pushed the 02-10-feat_double-click_to_edit_flex_nodes_in-place branch 2 times, most recently from 81d5a63 to 5307bcd Compare February 10, 2026 23:04
@camielvs camielvs mentioned this pull request Feb 10, 2026
Merged
3 tasks
@camielvs camielvs force-pushed the 02-10-feat_double-click_to_edit_flex_nodes_in-place branch from 5307bcd to 88c292b Compare February 10, 2026 23:36
@camielvs camielvs force-pushed the 02-09-feat_pack_flex_nodes_into_subgraphs branch 2 times, most recently from 75e7d09 to 1d457ec Compare February 11, 2026 00:08
@camielvs camielvs force-pushed the 02-10-feat_double-click_to_edit_flex_nodes_in-place branch from 88c292b to 7149787 Compare February 11, 2026 00:08
@camielvs camielvs force-pushed the 02-09-feat_pack_flex_nodes_into_subgraphs branch from 1d457ec to dd18105 Compare February 11, 2026 00:37
@camielvs camielvs force-pushed the 02-10-feat_double-click_to_edit_flex_nodes_in-place branch from 7149787 to 1f8f171 Compare February 11, 2026 00:37
@camielvs camielvs force-pushed the 02-09-feat_pack_flex_nodes_into_subgraphs branch from dd18105 to 83b0bc2 Compare February 11, 2026 00:55
@camielvs camielvs force-pushed the 02-10-feat_double-click_to_edit_flex_nodes_in-place branch 2 times, most recently from 8783994 to a8e9ed6 Compare February 11, 2026 01:04
@camielvs camielvs force-pushed the 02-09-feat_pack_flex_nodes_into_subgraphs branch from 83b0bc2 to 338b2c9 Compare February 11, 2026 01:04
@camielvs camielvs force-pushed the 02-10-feat_double-click_to_edit_flex_nodes_in-place branch from a8e9ed6 to 5fedf16 Compare February 17, 2026 18:38
@camielvs camielvs force-pushed the 02-09-feat_pack_flex_nodes_into_subgraphs branch 2 times, most recently from 132e265 to a8ff869 Compare February 17, 2026 20:34
@camielvs camielvs force-pushed the 02-10-feat_double-click_to_edit_flex_nodes_in-place branch from 5fedf16 to 9ea3881 Compare February 17, 2026 20:34
@camielvs camielvs force-pushed the 02-09-feat_pack_flex_nodes_into_subgraphs branch from a8ff869 to 71c9679 Compare February 17, 2026 20:57
@camielvs camielvs force-pushed the 02-10-feat_double-click_to_edit_flex_nodes_in-place branch from 9ea3881 to 7a2b0b6 Compare February 17, 2026 20:57
@camielvs camielvs force-pushed the 02-09-feat_pack_flex_nodes_into_subgraphs branch from 71c9679 to f78a5a9 Compare February 17, 2026 21:44
@camielvs camielvs force-pushed the 02-10-feat_double-click_to_edit_flex_nodes_in-place branch from 7a2b0b6 to e411246 Compare February 17, 2026 21:44
@camielvs camielvs marked this pull request as ready for review February 17, 2026 21:47
@camielvs camielvs requested a review from a team as a code owner February 17, 2026 21:47
@camielvs camielvs force-pushed the 02-09-feat_pack_flex_nodes_into_subgraphs branch from fb21cd5 to f2dff44 Compare February 19, 2026 20:51
@camielvs camielvs force-pushed the 02-10-feat_double-click_to_edit_flex_nodes_in-place branch 2 times, most recently from 914768a to a4dfffd Compare February 19, 2026 20:58
@camielvs camielvs force-pushed the 02-09-feat_pack_flex_nodes_into_subgraphs branch from f2dff44 to 59cdfbe Compare February 19, 2026 20:58
@camielvs camielvs force-pushed the 02-10-feat_double-click_to_edit_flex_nodes_in-place branch from a4dfffd to f5329e4 Compare February 19, 2026 21:00
@camielvs camielvs force-pushed the 02-09-feat_pack_flex_nodes_into_subgraphs branch from 59cdfbe to 2833586 Compare February 19, 2026 21:00
@camielvs camielvs force-pushed the 02-10-feat_double-click_to_edit_flex_nodes_in-place branch from f5329e4 to 6f5660e Compare February 19, 2026 21:01
@camielvs camielvs force-pushed the 02-09-feat_pack_flex_nodes_into_subgraphs branch 2 times, most recently from 02c12f3 to 2d65853 Compare February 19, 2026 21:04
@camielvs camielvs force-pushed the 02-10-feat_double-click_to_edit_flex_nodes_in-place branch from 6f5660e to 715bc2d Compare February 19, 2026 21:04
@camielvs camielvs force-pushed the 02-09-feat_pack_flex_nodes_into_subgraphs branch from 2d65853 to e34db9a Compare February 19, 2026 21:05
@camielvs camielvs force-pushed the 02-10-feat_double-click_to_edit_flex_nodes_in-place branch from 715bc2d to 311f0a5 Compare February 19, 2026 21:05
@camielvs camielvs force-pushed the 02-09-feat_pack_flex_nodes_into_subgraphs branch from e34db9a to fd4b595 Compare February 19, 2026 21:06
@camielvs camielvs force-pushed the 02-10-feat_double-click_to_edit_flex_nodes_in-place branch from 311f0a5 to fb1fafe Compare February 19, 2026 21:06
@camielvs camielvs force-pushed the 02-09-feat_pack_flex_nodes_into_subgraphs branch 3 times, most recently from c285f8b to 5d7fcf5 Compare February 19, 2026 22:36
@camielvs camielvs force-pushed the 02-10-feat_double-click_to_edit_flex_nodes_in-place branch from 0554632 to 3a7b139 Compare February 19, 2026 22:36
@camielvs camielvs changed the base branch from 02-09-feat_pack_flex_nodes_into_subgraphs to graphite-base/1783 February 19, 2026 22:39
@camielvs camielvs force-pushed the 02-10-feat_double-click_to_edit_flex_nodes_in-place branch from 3a7b139 to 0139585 Compare February 19, 2026 22:40
@graphite-app graphite-app bot changed the base branch from graphite-base/1783 to master February 19, 2026 22:40
@camielvs camielvs force-pushed the 02-10-feat_double-click_to_edit_flex_nodes_in-place branch from 0139585 to 919ad07 Compare February 19, 2026 22:40
@camielvs Graphite App
Copy link
Collaborator Author

camielvs commented Feb 19, 2026 •
edited
Loading

Merge activity

  • Feb 19, 10:45 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 19, 10:45 PM UTC: @camielvs merged this pull request with Graphite.

@camielvs camielvs merged commit 846c16a into master Feb 19, 2026
7 of 8 checks passed
@camielvs camielvs deleted the 02-10-feat_double-click_to_edit_flex_nodes_in-place branch February 19, 2026 22:45
This was referenced Feb 20, 2026
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxy-shpfy maxy-shpfy maxy-shpfy approved these changes

@Mbeaulne Mbeaulne Awaiting requested review from Mbeaulne

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camielvs @maxy-shpfy