Skip to content

Comments

feat: Add StackingControls for Managing zIndex#1756

Merged
camielvs merged 1 commit intomasterfrom
02-04-feat_add_zindex_management_for_all_nodes
Feb 19, 2026
Merged

feat: Add StackingControls for Managing zIndex#1756
camielvs merged 1 commit intomasterfrom
02-04-feat_add_zindex_management_for_all_nodes

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Feb 5, 2026

Description

Adds manual zIndex management to ReactFlow nodes. This is accessible in the UI via the new StackingControls component.

This PR adds:

  • Defaults & Ranges for allowable zIndices for each node type
  • Utilities for managing stacking actions (move to front/back etc)
  • A Component that consumes all of this and renders four interactive buttons for the user to control these features:
    • Move Forward
    • Move Backward
    • Bring to Front
    • Send to Back

This is an enabling PR for Flex Nodes, as manual zIndex management is a desired feature for Sticky Notes.

Motivation for a generalised solution:
Changing the default ReactFlow behaviour for zIndexMode from basic to manual results in nodes no longer being brought to front when selected. To mitigate this the PR brings the entire zIndex Management feature to all nodes so users can manually deal with the stacking themselves (rather than have no options at all). Upstack the feature will be added for Task and IO nodes.

Related Issue and Pull requests

Progresses https://github.com/Shopify/oasis-frontend/issues/483

Type of Change

  • New feature

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

Code-only change. The new component is not implemented anywhere in the UI. Go to upstack PRs to test.

Additional Comments

Note: this PR doesn't actually implement the new component anywhere in the UI - that comes upstack. Focus reviews on business logic and implementation.

Copy link
Collaborator Author

camielvs commented Feb 5, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camielvs camielvs force-pushed the 02-04-feat_add_zindex_management_for_all_nodes branch from bbf67bd to 47ed74b Compare February 5, 2026 00:23
@camielvs camielvs changed the title feat: Add zIndex Management for all Nodes feat: Add StackingControls for Managing zIndex Feb 5, 2026
@camielvs camielvs force-pushed the 01-30-chore_node_definition_cleanup branch from 851a7d9 to 8b7dbf9 Compare February 5, 2026 21:42
@camielvs camielvs force-pushed the 02-04-feat_add_zindex_management_for_all_nodes branch from 47ed74b to 017eef0 Compare February 5, 2026 21:42
@camielvs camielvs force-pushed the 01-30-chore_node_definition_cleanup branch from 8b7dbf9 to e547e8d Compare February 5, 2026 22:36
@camielvs camielvs force-pushed the 02-04-feat_add_zindex_management_for_all_nodes branch from 017eef0 to ae5afd2 Compare February 5, 2026 22:36
@camielvs camielvs force-pushed the 01-30-chore_node_definition_cleanup branch from e547e8d to c656456 Compare February 6, 2026 16:07
@camielvs camielvs force-pushed the 02-04-feat_add_zindex_management_for_all_nodes branch from ae5afd2 to 12359db Compare February 6, 2026 16:07
@camielvs camielvs force-pushed the 01-30-chore_node_definition_cleanup branch from c656456 to a2cb00e Compare February 6, 2026 19:43
@camielvs camielvs force-pushed the 02-04-feat_add_zindex_management_for_all_nodes branch 2 times, most recently from 6dff3a1 to ce36983 Compare February 6, 2026 19:49
@camielvs camielvs force-pushed the 01-30-chore_node_definition_cleanup branch from a2cb00e to c0c1214 Compare February 6, 2026 19:49
@camielvs camielvs force-pushed the 02-04-feat_add_zindex_management_for_all_nodes branch from a7a6429 to 7e1e9cd Compare February 18, 2026 23:18
@camielvs camielvs force-pushed the 01-30-chore_node_definition_cleanup branch from c59d689 to 872e475 Compare February 18, 2026 23:18
@camielvs camielvs force-pushed the 02-04-feat_add_zindex_management_for_all_nodes branch from 7e1e9cd to 350000b Compare February 19, 2026 00:23
@camielvs camielvs mentioned this pull request Feb 19, 2026
3 tasks
@camielvs camielvs force-pushed the 01-30-chore_node_definition_cleanup branch from 872e475 to b47c34c Compare February 19, 2026 17:59
@camielvs camielvs force-pushed the 02-04-feat_add_zindex_management_for_all_nodes branch from 350000b to ac6e50b Compare February 19, 2026 17:59
@camielvs camielvs force-pushed the 01-30-chore_node_definition_cleanup branch from b47c34c to f81ec04 Compare February 19, 2026 19:53
@camielvs camielvs force-pushed the 02-04-feat_add_zindex_management_for_all_nodes branch from ac6e50b to f9df251 Compare February 19, 2026 19:53
@camielvs camielvs changed the base branch from 01-30-chore_node_definition_cleanup to graphite-base/1756 February 19, 2026 19:57
@camielvs camielvs force-pushed the 02-04-feat_add_zindex_management_for_all_nodes branch from f9df251 to 4dfd416 Compare February 19, 2026 19:58
@graphite-app graphite-app bot changed the base branch from graphite-base/1756 to master February 19, 2026 19:58
@camielvs camielvs force-pushed the 02-04-feat_add_zindex_management_for_all_nodes branch 2 times, most recently from a2ef9b5 to 25650b0 Compare February 19, 2026 20:04
@camielvs camielvs force-pushed the 02-04-feat_add_zindex_management_for_all_nodes branch from 25650b0 to e36e164 Compare February 19, 2026 20:07
Copy link
Collaborator Author

camielvs commented Feb 19, 2026

Merge activity

  • Feb 19, 8:09 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 19, 8:10 PM UTC: @camielvs merged this pull request with Graphite.

@camielvs camielvs merged commit 8e10e5f into master Feb 19, 2026
7 of 8 checks passed
@camielvs camielvs deleted the 02-04-feat_add_zindex_management_for_all_nodes branch February 19, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants