Skip to content

Conversation

@KenVanHoeylandt
Copy link
Contributor

@KenVanHoeylandt KenVanHoeylandt commented Jan 31, 2026

Summary by CodeRabbit

  • New Features
    • Added a GPIO hardware abstraction layer for reading pin levels from applications.
    • Applications can now query the number of available GPIO pins so they can adapt to different devices.
  • Chores
    • Integrations updated so GPIO capabilities are discoverable and exported to running applications.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 31, 2026

📝 Walkthrough

Walkthrough

Adds GPIO pin-count and level functionality across layers. Introduces tt_hal_gpio.h and tt_hal_gpio.cpp with C APIs tt_hal_gpio_get_level and tt_hal_gpio_get_pin_count. Extends GpioControllerApi with get_pin_count and adds gpio_controller_get_pin_count plus GPIO_CONTROLLER_TYPE. Implements get_pin_count in the ESP32 GPIO driver and sets its deviceType. Exports the new HAL symbols in tt_init.cpp. Updates CMake to add TactilityKernel as a private dependency.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Partial reimplementation of TactilityC GPIO' accurately describes the main objective of the changeset, which adds GPIO HAL interface implementations across multiple files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch partial-reimplement-tactilityc-gpio

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (1)
TactilityC/Include/tt_hal_gpio.h (1)

10-13: Make GPIO_NO_PIN type-safe for unsigned GpioPin.

♻️ Suggested tweak
-#define GPIO_NO_PIN -1
+#define GPIO_NO_PIN ((GpioPin)-1)

@KenVanHoeylandt KenVanHoeylandt merged commit 399dca5 into main Jan 31, 2026
51 checks passed
@KenVanHoeylandt KenVanHoeylandt deleted the partial-reimplement-tactilityc-gpio branch January 31, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants