fix: fp16 config and grad scaling #1495
Open
+17
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure FP16 training is consistent and safe by setting required optimizer params, aligning fp16/bf16 flags, and avoiding duplicate grad scaling.
Changes
store_param_remainders=falseto reduce memory usage, since this option isn’t exposed by Megatron’s public config.Results
fp16 shows faster convergence speed and lower mismatch between training and rollout.
