Skip to content

Conversation

@BrianMichell
Copy link
Collaborator

I don't have a lot of understanding behind this style of data so the defaults and names likely need tweaking.

@BrianMichell BrianMichell requested a review from tasansal January 15, 2026 17:32
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.99%. Comparing base (c3ba558) to head (d9fd597).
⚠️ Report is 224 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
+ Coverage   85.30%   88.99%   +3.68%     
==========================================
  Files          46      101      +55     
  Lines        2219     5744    +3525     
  Branches      306      383      +77     
==========================================
+ Hits         1893     5112    +3219     
- Misses        281      538     +257     
- Partials       45       94      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@markspec
Copy link
Contributor

from mdio.builder.templates.seismic_3d_obn import Seismic3DObnReceiverGathersTemplate
from mdio.builder.templates.seismic_3d_obn_single_component import Seismic3DObnSingleComponentGathersTemplate

I vote we chunk Component as 1 and then use the same template!

I also think this default is sub-optimal:

    self._var_chunk_shape = (4, 8, 1, 2, 8, 4096)

There are often 3 guns... Rarely do we pull multiple receivers. I think we only really care about access in shot-point and depth. Also a chunks size of > 1 for receiver will prevent us from streaming nodes :-( a huge operational bottle-neck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants