Skip to content

Conversation

@cubic-dev-ai
Copy link

@cubic-dev-ai cubic-dev-ai bot commented Dec 19, 2025

🤖 PR by cubic

This PR addresses the comment in #8 – Add wb-data-scrumb.js from Engine branch

File: examples/src/static/index.html
Line: 11
Comment:

P2: Tailwind's Play CDN (cdn.tailwindcss.com) is intended for development/prototyping only, not production use. Since this file is deployed to playcanvas.github.io, consider either:

  1. Using a proper Tailwind build process with PostCSS
  2. Using pre-built Tailwind CSS from a CDN like https://cdn.jsdelivr.net/npm/tailwindcss@latest/dist/tailwind.min.css
  3. Writing plain CSS for this small widget

This fix was automatically generated. Please review the changes carefully before merging.


Summary by cubic

Replaced Tailwind Play CDN in the static example with local, production-safe CSS for the World Clocks widget. Addresses the review comment in #8 and removes the dev-only dependency.

  • Refactors
    • index.html: removed cdn.tailwindcss.com and Tailwind utility classes; added semantic classes.
    • styles.css: added scoped styles for #world-clocks and its children (layout, colors, typography, hover).
    • Preserves the same UI while avoiding runtime Tailwind and extra network calls.

Written for commit 6fb1b51. Summary will update automatically on new commits.

@coderabbitai
Copy link

coderabbitai bot commented Dec 19, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Author

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Copy link
Author

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Copy link
Author

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@JaclynCodes JaclynCodes merged commit 2fe4b2e into copilot/update-branch-with-latest-commit Dec 19, 2025
3 checks passed
@JaclynCodes JaclynCodes deleted the cubic-fix-examples-src-static-index-html-L11-1766119199 branch December 19, 2025 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants