refactor: remove V1 resources #4281
Conversation
|
I guess this replaces #4279 ? |
|
Replaces or complements |
|
yes, no problem, close #4279 if we already have a superset of the changes here. |
olevski
left a comment
olevski
left a comment
There was a problem hiding this comment.
I mentioned a few extra things that can be removed. If you want you can also do them in a followup PR.
| test: | ||
| enabled: false | ||
| ## Configuration for renku-graph services | ||
| graph: |
There was a problem hiding this comment.
A few more things can be removed:
- .global.core
- .global.graph
- .dlf-chart
- .jena
There was a problem hiding this comment.
There are even a few more sections that can be removed. But these "other sections" I did not mention above, because they all need code changes in the data service before we can remove them from here.
There was a problem hiding this comment.
Seeing the conflict in values.yaml, is the dlf-chart still to be removed ?
|
Oh and please add |
sgaist
force-pushed
the
refactor/remove-obsolete-items
branch
from
c1f59bd to
479fadd
Compare
|
You can access the deployment of this PR at https://ci-renku-4281.dev.renku.ch |
olevski
force-pushed
the
release-2.12.0
branch
from
c142fa8 to
3e27337
Compare
rokroskar
force-pushed
the
release-2.13.0
branch
from
b12f8ad to
a1a92dc
Compare
They are obsolete and unused components
This folder can be created when testing locally.
Co-authored-by: Tasko Olevski <tasko.olevski@sdsc.ethz.ch>
Explicitly hard code it and webhooks as to-be-removed as they are v1 only features
sgaist
force-pushed
the
refactor/remove-obsolete-items
branch
from
af18a1f to
b4b5906
Compare
leafty
left a comment
leafty
left a comment
There was a problem hiding this comment.
UI is broken by this change. Will push fix to the PR.
| - name: LEGACY_SUPPORT | ||
| value: {{ dict "enabled" .Values.enableV1Services "supportLegacySessions" .Values.ui.client.supportLegacySessions | toJson | quote }} |
There was a problem hiding this comment.
We need to keep this configuration around for now.
leafty
left a comment
leafty
left a comment
There was a problem hiding this comment.
Look good, we need to test with gitlab.
Describe your changes
This PR removes the
enableV1Servicesflag as well as all the resources behind it from the helm chart.Issue(s) ticket number(s) and link(s)
Fixes #4280
/deploy #slow