Replace any type with proper ical-generator types for type safety#2
Draft
Copilot wants to merge 2 commits intofeat/basic-ocrfrom
Draft
Replace any type with proper ical-generator types for type safety#2Copilot wants to merge 2 commits intofeat/basic-ocrfrom
any type with proper ical-generator types for type safety#2Copilot wants to merge 2 commits intofeat/basic-ocrfrom
Conversation
Merged
Co-authored-by: ghostleek <44336310+ghostleek@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update basic OCR implementation based on feedback
Replace Jan 1, 2026
any type with proper ical-generator types for type safety
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses type safety feedback on PR #1 regarding the use of
anytype for the recurrence rule object inlib/ical-generator.ts.Changes:
ICalRepeatingOptionsandICalEventRepeatingFreqfrom ical-generatoranytype annotation withICalRepeatingOptionsfor rrule variableICalEventRepeatingFreq.WEEKLYenum instead of string literal'WEEKLY'Before:
After:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.