Refactor useSwipe to separate event handlers from state#19
Draft
Copilot wants to merge 3 commits intofeat/personal-sitefrom
Draft
Refactor useSwipe to separate event handlers from state#19Copilot wants to merge 3 commits intofeat/personal-sitefrom
Copilot wants to merge 3 commits intofeat/personal-sitefrom
Conversation
Merged
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: ghostleek <44336310+ghostleek@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback from review on personal site feature implementation
Refactor useSwipe to separate event handlers from state
Feb 12, 2026
Contributor
|
@copilot can you resolve the merge conflicts and confirm if this is still necessary? |
Co-authored-by: ghostleek <44336310+ghostleek@users.noreply.github.com>
Contributor
Author
Resolved merge conflicts in commit f514681. This PR is still necessary - the main branch currently spreads all useSwipe return values (including state like This PR maintains the fix that separates event handlers into a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spreading the full
useSwipe()return object onto DOM elements passes non-standard props (state values and helper functions), which should only receive standard HTML attributes and event handlers.Changes:
useSwipehook to return event handlers in a separatehandlersobjectPinnedAppCardandAppGridCardto explicitly spread only touch/click handlersBefore:
After:
Note: This PR has been rebased onto main after the base branch
feat/personal-sitewas merged. The fix remains necessary as the main branch still spreads all properties directly onto DOM elements.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.