Open
Conversation
santosral
force-pushed
the
feat/admin-app
branch
3 times, most recently
from
05232fc to
ea2bce6
Compare
santosral
requested review from
YimingIsCOLD and
nicholasjjlim
and removed request for
YimingIsCOLD
santosral
force-pushed
the
feat/admin-app
branch
from
ea2bce6 to
58313e3
Compare
Collaborator
|
For the login flow implementation, thinking we should keep the login to app and admin sites separate. Suggest we can have 2 separate routes:
Each of their login session states should be kept separate, so admin and app should each have their own states. |
santosral
force-pushed
the
feat/admin-app
branch
from
58313e3 to
8b6c774
Compare
santosral
force-pushed
the
feat/admin-app
branch
4 times, most recently
from
4c29a8d to
2bbcaa4
Compare
santosral
force-pushed
the
feat/admin-app
branch
from
2bbcaa4 to
11fb93c
Compare
santosral
force-pushed
the
feat/admin-app
branch
from
a8c67ce to
011317f
Compare
| event.setHeaders({ 'X-Request-Id': requestId }); | ||
| event.locals.logger = logger.child({ requestId, module: 'admin' }); | ||
|
|
||
| return await resolve(event); |
Collaborator
There was a problem hiding this comment.
no need for await here. refer to comments in #484
same for the rest of the page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Summary
This PR is adds the admin application to solve the problem of manually doing the import of Glow's content to the database.
✏️ Changes