Use communityGiftPurchase Activity to add time from bulk gifts#7
Draft
mojobeast wants to merge 1 commit intoStreamElements:masterfrom
Draft
Use communityGiftPurchase Activity to add time from bulk gifts#7mojobeast wants to merge 1 commit intoStreamElements:masterfrom
mojobeast wants to merge 1 commit intoStreamElements:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5
This fix relies on my working theory that subscriber events are being sent too quickly to be processed after a bulk community sub gift event, and some are being dropped. Instead, it uses the communityGiftPurchase Activity to add the correct amount of time.
This is a draft PR because it is entirely UNTESTED - largely because I can't find a VS Code extension that actually supports the requirements listed in https://dev.streamelements.com/docs/widgets-elements-sdk/bult8ogswaeu2-setup-guide (the instructions that the article suggests do not work).
If anyone knows of an extension that actually supports both CORS and CSP - or, really, any working instructions for setting up a dev environment for the Elements SDK - please let me know and I will test this properly.