Skip to content

Fix: Clear project selection after removing a project #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lrasmus merged 1 commit into from
Feb 4, 2026
Merged

Fix: Clear project selection after removing a project #308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions app/containers/ProjectPage/ProjectPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ class ProjectPage extends Component {

this.handleLoadProjectListResponse = this.handleLoadProjectListResponse.bind(this);
this.refreshProjectsHandler = this.refreshProjectsHandler.bind(this);
this.handleRemoveProjectListEntryResponse = this.handleRemoveProjectListEntryResponse.bind(this);
this.handleFavoriteClick = this.handleFavoriteClick.bind(this);
this.handleAddProject = this.handleAddProject.bind(this);
this.handleCloseAddProject = this.handleCloseAddProject.bind(this);
Expand Down Expand Up @@ -91,7 +92,7 @@ class ProjectPage extends Component {
ipcRenderer.on(Messages.LOAD_CONFIGURATION_RESPONSE, this.handleLoadConfigurationResponse);

ipcRenderer.on(Messages.TOGGLE_PROJECT_FAVORITE_RESPONSE, this.refreshProjectsHandler);
ipcRenderer.on(Messages.REMOVE_PROJECT_LIST_ENTRY_RESPONSE, this.refreshProjectsHandler);
ipcRenderer.on(Messages.REMOVE_PROJECT_LIST_ENTRY_RESPONSE, this.handleRemoveProjectListEntryResponse);
ipcRenderer.on(Messages.RENAME_PROJECT_LIST_ENTRY_RESPONSE, this.refreshProjectsHandler);
ipcRenderer.on(Messages.SCAN_PROJECT_RESPONSE, this.handleScanProjectResponse);
ipcRenderer.on(Messages.SCAN_PROJECT_RESULTS_RESPONSE, this.handleScanProjectResultsResponse);
Expand Down Expand Up @@ -132,7 +133,7 @@ class ProjectPage extends Component {
);
ipcRenderer.removeListener(
Messages.REMOVE_PROJECT_LIST_ENTRY_RESPONSE,
this.refreshProjectsHandler,
this.handleRemoveProjectListEntryResponse,
);
ipcRenderer.removeListener(
Messages.RENAME_PROJECT_LIST_ENTRY_RESPONSE,
Expand Down Expand Up @@ -292,6 +293,20 @@ class ProjectPage extends Component {
ipcRenderer.send(Messages.LOAD_PROJECT_LIST_REQUEST);
}

handleRemoveProjectListEntryResponse(sender, response) {
// If the removed project is currently selected, clear the selection
if (this.state.selectedProject && response.projectId === this.state.selectedProject.id) {
this.setState({
selectedProject: null,
selectedProjectLogs: null,
selectedProjectChecklist: null,
assetDynamicDetails: null,
});
}
// Refresh the project list
this.refreshProjectsHandler();
}

handleProjectExternallyChangedResponse(sender, response) {
// If any project externally changes - even if it's not the one we currently have selected - we want
// to reload the project log and checklist, so we can detect changes and notify (if needed);
Expand Down