-
Notifications
You must be signed in to change notification settings - Fork 0
Switch all workflows to ubuntu-slim except GitOps #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| update_release_draft: | ||
| name: update release draft | ||
| runs-on: ubuntu-24.04 | ||
| runs-on: ubuntu-slim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't use the slim thing here since this is on the release production path and therefore time to market will be decreased when change this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my intuition this shouldn't become slower. The release-drafter action is a nodejs action which means it runs single-threaded anyway. So the switch to 1vCPU shouldn't matter 🤔 ?
If ubuntu-slim runs in a container instead of a VM we might even experience faster cold starts 🤔
This line of thinking applies to all actions you commented on.
Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds reasonable. 👍
One thought: NodeJS allows spawning child processes which are then decoupled from the parent event loop and therefore the assumption "it's nodejs it will def. only use one CPU" is not correct.
stefanmeschke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to monitor this change ofc. 😊
From my point of view there are labels missing on this PR in order to mark this PR as major change etc.
Type of Change
Description
If you think any actions should not run in this slim version please flag it. GitOps comes to mind because building Dockerfiles might be heavy.
Checklist