Skip to content

Conversation

@slimi-so
Copy link
Contributor

@slimi-so slimi-so commented Dec 23, 2025

  • Removes Germany and AzureGermany() constant from /client/config directory, and from environments file
  • evidence that Germany is removed:
bed_4601_2

Closes: BED-4601

Summary by CodeRabbit

  • Chores
    • Removed support for the Germany Azure region. Germany is no longer available as a configuration option and has been removed from environment endpoints and region settings.

✏️ Tip: You can customize this high-level summary in your review settings.



- Removes Germany and AzureGermany() constant from /client/config directory, and from environments file

Closes: BED-4601
@coderabbitai
Copy link

coderabbitai bot commented Dec 23, 2025

Walkthrough

Removal of Germany region support from the Azure SDK configuration. The Germany constant, AzureGermany environment function, and all Germany-specific URL resolver logic have been deleted across configuration and constants files.

Changes

Cohort / File(s) Summary
Constants & Environment Definitions
constants/environments.go
Removed public constant Germany and function AzureGermany() that previously defined German Azure endpoints. This eliminates Germany as a supported region at the constant level.
Region Configuration
config/config.go
Removed Germany from the AzRegions initialization slice. The region list now contains only China, Cloud, USGovL4, and USGovL5.
URL Resolver Functions
client/config/config.go
Removed Germany case handling from three URL resolver functions: AuthorityUrl, GraphUrl, and ResourceManagerUrl. Default fallback behavior remains unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A farewell to the German cloud so fine,
We've bid it farewell with a hop and a line,
Constants now trimmed, URLs refined,
Leaving just the regions we keep in mind!
One region removed, but the rest stay true,
Simpler configs—that's what we do! 🌍✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the main change: removal of the Azure Germany region from AzureHound configuration across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch BED-4601-remove-germany

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@urangel urangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@slimi-so slimi-so merged commit 752e8a4 into main Dec 23, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants