Add the dashboard from datasister as a Pane #130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't literally inject the module, since it determines the current user in a different way (based on who's logged in rather than on which Pod we're running), so this is currently a copy-paste of most code in there, with a few import paths changed around. Still, it at least shows where to copy changes from datasister into, and vice versa: it maintains a similar overall structure, so modifications made here can relatively easily be carried over to datasister.
Contributor
|
This feature was made obsolete by the introduction of global dashboard by @timbl. Closing this PR for now. Reopen if you want to continue this work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't literally inject the module, since it determines the
current user in a different way (based on who's logged in rather
than on which Pod we're running), so this is currently a copy-paste
of most code in there, with a few import paths changed around.
Still, it at least shows where to copy changes from datasister
into, and vice versa: it maintains a similar overall structure, so
modifications made here can relatively easily be carried over to
datasister.
Note that this builds on #117, which wasn't merged yet. Thus, for reviewing it's probably easiest to just focus on these changes: 760db5c