Apply code review feedback: fix formatting and remove unused imports#6
Merged
argahsuknesib merged 2 commits intodictionary-encodingfrom Nov 5, 2025
Merged
Apply code review feedback: fix formatting and remove unused imports#6argahsuknesib merged 2 commits intodictionary-encodingfrom
argahsuknesib merged 2 commits intodictionary-encodingfrom
Conversation
10 tasks
Co-authored-by: argahsuknesib <87450516+argahsuknesib@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add dictionary encoding implementation for RDF term storage
Apply code review feedback: fix formatting and remove unused imports
Nov 5, 2025
Collaborator
argahsuknesib
left a comment
argahsuknesib
left a comment
There was a problem hiding this comment.
Great work, looks good to me.
| object: dict.fetch_uri(self.object).unwrap_or("UNKNOWN").to_string(), | ||
| graph: dict.fetch_uri(self.graph).unwrap_or("UNKNOWN").to_string() | ||
| } | ||
| graph: dict.fetch_uri(self.graph).unwrap_or("UNKNOWN").to_string(), |
Collaborator
There was a problem hiding this comment.
Do you always need an extra , even if there is nothing else after it? Why?
| index_path: &str, | ||
| ) -> std::io::Result<()> { | ||
| #[doc = ""] | ||
| pub fn build_dense_index(log_path: &str, index_path: &str) -> std::io::Result<()> { |
Collaborator
There was a problem hiding this comment.
Why do you prefer writing in single line than 2 different? Two different ones have better readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review comments from PR #5 requesting style consistency and cleanup.
Changes Made
ResolvedEventstruct declarationselfqualifier from dictionary module importrustfmtto ensure consistent formatting across modified files (import ordering, spacing, trailing commas)All changes are purely stylistic with no functional impact.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.