Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds logging statements to the Authentication middleware to improve debugging and monitoring capabilities. The changes add log output for various error conditions that can occur during the authentication flow.
Changes:
- Added log statements for four error scenarios in the authentication middleware: request creation failure, session validation failure, response reading failure, and JSON parsing failure
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| requestUrl := fmt.Sprintf("%s/%s", serviceconfig.GetConfig().ApiRootUrl, "auth/session") | ||
| request, err := http.NewRequest("GET", requestUrl, nil) | ||
| if err != nil { | ||
| log.Printf("[AUTH] Failed to contacft auth service at %s: %v", requestUrl, err) |
There was a problem hiding this comment.
There is a spelling error in the log message: "contacft" should be "contact".
Suggested change
| log.Printf("[AUTH] Failed to contacft auth service at %s: %v", requestUrl, err) | |
| log.Printf("[AUTH] Failed to contact auth service at %s: %v", requestUrl, err) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.