Skip to content

Postpone updating commandResult #2765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HunsupJung wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Postpone updating commandResult #2765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 24 additions & 11 deletions drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1662,17 +1662,6 @@ local function set_pin_response_handler(driver, device, ib, response)
add_credential_to_table(device, userIdx, credIdx, "pin")
end

-- Update commandResult
local command_result_info = {
commandName = cmdName,
userIndex = userIdx,
credentialIndex = credIdx,
statusCode = status
}
device:emit_event(capabilities.lockCredentials.commandResult(
command_result_info, {state_change = true, visibility = {displayed = false}}
))

-- If User Type is Guest and device support schedule, add default schedule
local week_schedule_eps = device:get_endpoints(DoorLock.ID, {feature_bitmap = DoorLock.types.Feature.WEEK_DAY_ACCESS_SCHEDULES})
local year_schedule_eps = device:get_endpoints(DoorLock.ID, {feature_bitmap = DoorLock.types.Feature.YEAR_DAY_ACCESS_SCHEDULES})
Expand All @@ -1696,6 +1685,16 @@ local function set_pin_response_handler(driver, device, ib, response)
)
)
else
-- Update commandResult
local command_result_info = {
commandName = cmdName,
userIndex = userIdx,
credentialIndex = credIdx,
statusCode = status
}
device:emit_event(capabilities.lockCredentials.commandResult(
command_result_info, {state_change = true, visibility = {displayed = false}}
))
device:set_field(lock_utils.BUSY_STATE, false, {persist = true})
end
return
Expand Down Expand Up @@ -2371,6 +2370,20 @@ local function set_year_day_schedule_handler(driver, device, ib, response)
end

if cmdName == "defaultSchedule" then
local cmdName = "addCredential"
local credIdx = device:get_field(lock_utils.CRED_INDEX)

-- Update commandResult
local command_result_info = {
commandName = cmdName,
userIndex = userIdx,
credentialIndex = credIdx,
statusCode = status
}
device:emit_event(capabilities.lockCredentials.commandResult(
command_result_info, {state_change = true, visibility = {displayed = false}}
))
device:set_field(lock_utils.BUSY_STATE, false, {persist = true})
return
end

Expand Down
Loading