Skip to content

Add support for additional Closure device types #2751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nickolas-deboom wants to merge 4 commits into
base: migrate-window-covering-driver-to-matter-switch
Choose a base branch
from
Open

Add support for additional Closure device types #2751

nickolas-deboom wants to merge 4 commits into from

Conversation

@nickolas-deboom
Copy link
Contributor

@nickolas-deboom nickolas-deboom commented Feb 3, 2026 •
edited
Loading

This adds support for the Covering, Gate, Door, and GarageDoor closure subtypes.

#2714 is a prerequisite for this PR.

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Duplicate profile check: Warning - duplicate profiles detected.
door.yml == gate.yml

nickolas-deboom
nickolas-deboom commented Feb 3, 2026
View reviewed changes
drivers/SmartThings/matter-switch/profiles/gate.yml
- id: refresh
version: 1
categories:
- name: Door
Copy link
Contributor Author

@nickolas-deboom nickolas-deboom Feb 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A request for a new Gate category has been opened, and once that's published we can update the category here to reflect that

@nickolas-deboom nickolas-deboom force-pushed the support-additional-closure-types branch from ce17223 to 4803fa1 Compare February 3, 2026 21:43
@github-actions
Copy link

github-actions bot commented Feb 3, 2026 •
edited
Loading

File Coverage
All files 89% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_utils/embedded_cluster_utils.lua 38% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_utils/utils.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/init.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded_clusters/ClosureControl/types/CurrentPositionEnum.lua 68% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded_clusters/ClosureControl/types/Feature.lua 50% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded_clusters/ClosureControl/types/MainStateEnum.lua 71% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded_clusters/ClosureControl/types/TargetPositionEnum.lua 69% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded_clusters/ClosureControl/types/OverallTargetStateStruct.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded_clusters/ClosureControl/types/OverallCurrentStateStruct.lua 51% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_handlers/capability_handlers.lua 78% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_handlers/attribute_handlers.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/closures/init.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/third_reality_mk1/init.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded_clusters/ClosureControl/server/attributes/OverallTargetState.lua 78% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded_clusters/ClosureControl/server/attributes/OverallCurrentState.lua 62% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded_clusters/ClosureControl/server/attributes/MainState.lua 78% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/eve_energy/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/aqara_cube/init.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded_clusters/ClosureControl/init.lua 71% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/closures/closure_handlers/capability_handlers.lua 85% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/closures/closure_handlers/attribute_handlers.lua 79% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/ikea_scroll/init.lua 85% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_utils/utils.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_utils/device_configuration.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_handlers/capability_handlers.lua 89% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_handlers/event_handlers.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_handlers/attribute_handlers.lua 86% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded_clusters/ClosureControl/server/commands/init.lua 58% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 96% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 6128583

@github-actions
Copy link

github-actions bot commented Feb 3, 2026 •
edited
Loading

Test Results

   71 files  ±0    485 suites  +1   0s ⏱️ ±0s
2 498 tests ±0  2 498 ✅ ±0  0 💤 ±0  0 ❌ ±0 
4 317 runs  +1  4 317 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 6128583. ± Comparison against base commit ca9c2e7.

♻️ This comment has been updated with latest results.

@nickolas-deboom
Add support for additional Closure device types
b0c7eb5 
This adds support for Coverings, Gate, Doors, and GarageDoors closure subtypes.
@nickolas-deboom nickolas-deboom force-pushed the support-additional-closure-types branch from 4803fa1 to b0c7eb5 Compare February 4, 2026 16:02
@nickolas-deboom nickolas-deboom force-pushed the support-additional-closure-types branch from 16b02c7 to 2b519fa Compare February 4, 2026 22:15
@nickolas-deboom nickolas-deboom force-pushed the support-additional-closure-types branch from 2b519fa to 97b819c Compare February 4, 2026 22:16
@nickolas-deboom nickolas-deboom force-pushed the support-additional-closure-types branch 2 times, most recently from 0b53893 to 6128583 Compare February 5, 2026 18:33
@nickolas-deboom nickolas-deboom force-pushed the support-additional-closure-types branch from 6128583 to 093a09b Compare February 10, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hcarter-775 hcarter-775 Awaiting requested review from hcarter-775

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nickolas-deboom