WWSTCERT-10189 Ledvance zigbee meter plug #2729

LQ107 · 2026-01-26T10:10:59Z

Check all that apply

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

greens · 2026-02-04T19:14:19Z

drivers/SmartThings/zigbee-switch/config.yml

+fingerprints:
+  - manufacturer: "LEDVANCE"
+    model: "PLUG COMPACT EU EM T"
+    deviceProfileName: "switch-power-energy"
+    id: "LEDVANCE/PLUG COMPACT EU EM T"
+    deviceLabel: "SMART ZIGBEE COMPACT OUTDOOR PLUG EU"


please remove the changes to this file

greens · 2026-02-04T19:14:51Z

drivers/SmartThings/zigbee-switch/fingerprints.yml

    deviceProfileName: basic-switch
-  - id: "JNL/Y-K001-001"
-    deviceLabel: Yanmi Switch (1 Way) 
-    manufacturer: JNL
-    model: Y-K001-001
-    deviceProfileName: basic-switch  
-  - id: "JNL/Y-K002-001"
-    deviceLabel: Yanmi Switch (2 Way) 1
-    manufacturer: JNL
-    model: Y-K002-001
-    deviceProfileName: basic-switch
 zigbeeGeneric:


please do not remove other partners' fingerprints

greens · 2026-02-04T19:16:35Z

drivers/SmartThings/zigbee-switch/src/simple-metering-config/fingerprints.lua

I'm unsure where this file is used?

greens · 2026-02-04T19:18:31Z

drivers/SmartThings/zigbee-switch/src/simple-metering-config/can_handle.lua

+local can_handle_simple_metering_config = function(opts, driver, device)
+  -- 检查设备是否支持 Simple Metering 集群 (0x0702)
+  for _, cluster in ipairs(device.server_clusters) do
+    if cluster == 0x0702 then


we have other devices for which this would return true where we would not want your specific device's logic to be used, which is why we usually gate subdrivers via fingerprints

greens · 2026-02-04T19:21:07Z

drivers/SmartThings/zigbee-switch/src/simple-metering-config/init.lua

+local function device_init(driver, device)
+  -- 在设备初始化时设置 multipliers 和 divisors
+  device:configure()
+
+  -- 设置 Multiplier 为 1
+  local write_multiplier_cmd = SimpleMetering.server.commands.WriteAttributes(device)
+  if write_multiplier_cmd then
+    device:send_to_component(
+      write_multiplier_cmd({
+        {id = SimpleMetering.attributes.Multiplier.ID, value = 1, DataType = 0x22} -- 0x22 is 24-bit integer
+      }),
+      "main"
+    )
+  end
+
+  -- 设置 Divisor 为 100
+  local write_divisor_cmd = SimpleMetering.server.commands.WriteAttributes(device)
+  if write_divisor_cmd then
+    device:send_to_component(
+      write_divisor_cmd({
+        {id = SimpleMetering.attributes.Divisor.ID, value = 100, DataType = 0x23} -- 0x23 is 32-bit integer
+      }),
+      "main"
+    )
+  end
+end


It is often the case that the driver init event happens before the radio is up after a hub restart, resulting in zigbee messages failing to be sent. I would recommend moving these to added or configure, since they likely do not need to be re-sent to the device every time they hub restarts.

greens · 2026-02-04T19:24:10Z

drivers/SmartThings/zigbee-switch/src/simple-metering-config/init.lua

+  local divisor = device:get_field(SimpleMetering.attributes.Divisor.ID) or 100
+  local multiplier = device:get_field(SimpleMetering.attributes.Multiplier.ID) or 1


this field is not likely to be set. We do set a similar field from "st.zigbee.constants": constants.SIMPLE_METERING_MULTIPLIER_KEY (and divisor) in our defaults, but we never use the attribute ID as a key,

greens · 2026-02-04T19:26:17Z

drivers/SmartThings/zigbee-switch/src/simple-metering-config/init.lua

+  if write_multiplier_cmd then
+    device:send_to_component(
+      write_multiplier_cmd({
+        {id = SimpleMetering.attributes.Multiplier.ID, value = 1, DataType = 0x22} -- 0x22 is 24-bit integer


we provide "st.zigbee.data_types" which has a Int24 (and Int32 constant)

greens · 2026-02-04T19:26:49Z

drivers/SmartThings/zigbee-switch/src/simple-metering-config/init.lua

+  if write_divisor_cmd then
+    device:send_to_component(
+      write_divisor_cmd({
+        {id = SimpleMetering.attributes.Divisor.ID, value = 100, DataType = 0x23} -- 0x23 is 32-bit integer


in the ZCL this attribute is an Int24

greens

It seems fairly obvious that your AI agent was not up to the task here.

LQ107 · 2026-02-11T05:08:12Z

Hi Steven ， I have updated the driver according to the suggestion you provided. Please help me review it again, thank you very much . Best regards! Long,Jack ***@***.*** 发件人: Steven Green ***@***.***> 发送时间: 2026年2月5日 4:23 收件人: SmartThingsCommunity/SmartThingsEdgeDrivers ***@***.***> 抄送: Long, Jack ***@***.***>; Author ***@***.***> 主题: Re: [SmartThingsCommunity/SmartThingsEdgeDrivers] WWSTCERT-10189 Ledvance zigbee meter plug (PR #2729) You don't often get email from ***@***.******@***.***>. Learn why this is important<https://aka.ms/LearnAboutSenderIdentification> @greens commented on this pull request.

________________________________ In drivers/SmartThings/zigbee-switch/fingerprints.yml<#2729 (comment)>:

- - id: "JNL/Y-K001-001"

- deviceLabel: Yanmi Switch (1 Way) - manufacturer: JNL - model: Y-K001-001 - deviceProfileName: basic-switch - - id: "JNL/Y-K002-001" - deviceLabel: Yanmi Switch (2 Way) 1 - manufacturer: JNL - model: Y-K002-001 - deviceProfileName: basic-switch zigbeeGeneric: please do not remove other partners' fingerprints ― Reply to this email directly, view it on GitHub<#2729 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/B32Y5R5HB5C67Q7L5IPRYLD4KJII5AVCNFSM6AAAAACS4NOPFCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTONJSHA4TGMRYHE>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

greens · 2026-02-11T23:26:56Z

drivers/SmartThings/zigbee-switch/src/simple-metering-config/init.lua

+local function energy_meter_handler(driver, device, value, zb_rx)
+  local raw_value = value.value
+
+  if type(raw_value) ~= "number" or raw_value < 0 then
+    return
+  end
+
+  local divisor = device:get_field(zigbee_constants.SIMPLE_METERING_DIVISOR_KEY) or 100
+  local multiplier = device:get_field(zigbee_constants.SIMPLE_METERING_MULTIPLIER_KEY) or 1
+
+  if divisor == 0 then
+    return
+  end
+
+  local calculated_value = (raw_value * multiplier) / divisor
+
+  device:emit_event_for_endpoint(
+    zb_rx.address_header.src_endpoint.value,
+    capabilities.energyMeter.energy({ value = calculated_value, unit = "kWh" })
+  )
+end


our default handlers should handle this case, provided your device properly reports its simple metering multiplier and divisor.

greens · 2026-02-11T23:27:03Z

drivers/SmartThings/zigbee-switch/src/simple-metering-config/init.lua

@@ -0,0 +1,44 @@
+-- Copyright 2025 SmartThings, Inc.


greens

Based on what you have here, I think all you need to add is the entry in fingerprints.yml. There does not seem to be any device-specific behavior that is different from our default handlers.

LQ107 added 6 commits January 26, 2026 17:55

ledvance zigbee meter plug driver pull

c8278e8

add the handle file

316276d

add driver fingerprints

c01a9d0

modify the ledvance zigbee meter plug device Label

5e5a387

add driver for PLUG EU EM T

98aafe1

delete the PLUG EU EM T driver

6a76283

greens changed the title ~~Ledvance zigbee meter plug~~ WWSTCERT-10189 Ledvance zigbee meter plug Feb 4, 2026

greens reviewed Feb 4, 2026

View reviewed changes

drivers/SmartThings/zigbee-switch/src/simple-metering-config/fingerprints.lua

Copy link

Contributor

greens Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure where this file is used?

greens reviewed Feb 4, 2026

View reviewed changes

greens requested changes Feb 4, 2026

View reviewed changes

Update the PLUG COMPACT EU EM T device driver

14de7ba

greens reviewed Feb 11, 2026

View reviewed changes

drivers/SmartThings/zigbee-switch/src/simple-metering-config/init.lua

@@ -0,0 +1,44 @@

-- Copyright 2025 SmartThings, Inc.

Copy link

Contributor

greens Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

date

greens requested changes Feb 11, 2026

View reviewed changes

		local divisor = device:get_field(SimpleMetering.attributes.Divisor.ID) or 100
		local multiplier = device:get_field(SimpleMetering.attributes.Multiplier.ID) or 1

WWSTCERT-10189 Ledvance zigbee meter plug #2729

Are you sure you want to change the base?

WWSTCERT-10189 Ledvance zigbee meter plug #2729

Uh oh!

Conversation

LQ107 commented Jan 26, 2026

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greens Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greens left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LQ107 commented Feb 11, 2026 via email

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greens left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

greens Feb 4, 2026 •

edited

Loading

greens left a comment •

edited

Loading