Add support for Folia#10
Open
TeddyBear2004 wants to merge 2 commits intoSimplexity-Development:masterfrom
Open
Add support for Folia#10TeddyBear2004 wants to merge 2 commits intoSimplexity-Development:masterfrom
TeddyBear2004 wants to merge 2 commits intoSimplexity-Development:masterfrom
Conversation
Member
|
Heyo, thank you for the PR! Before I can do a proper review of it, I am going to need some more information on the actual testing you've done on this. I am not familiar enough with the Folia ecosystem to know which methods and such translate over without issue and which don't - but I do know that Folia fundamentally changes how things are ticked, especially entities. I am not sure that this plugin will work properly with only the runnables moved over. Main things I'm concerned about are
Please report back on how the testing goes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.