Update GitHub Action Inputs to be more cohesive #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-page
requested review from
BPScott,
aaronccasanova,
oluwatimio,
robin-drexler and
vividviolet
README.md
Outdated
|
|
||
| | Inputs (All Optional) | Description | | ||
| | --------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | `comment_command` | Default: `/snapit`. Comma seperated list of comments to write to trigger the creation of a snapshot. | |
Member
There was a problem hiding this comment.
The fact that comment_command starts with comment_ is confusing because it's not related to the other inputs that start with comment_. This one here is the trigger whereas the others configure the comment snapit makes after creating the snapshot.
Maybe we'd call this one trigger_comment or trigger_phrase?
Member
Author
There was a problem hiding this comment.
Thanks @robin-drexler I think that is good feedback. I'll make some tweaks after hackdays.
robin-drexler
approved these changes
Jun 17, 2025
aaronccasanova
approved these changes
Jun 17, 2025
alex-page
force-pushed
the
main
branch
3 times, most recently
from
b15ee45 to
ddbc2f3
Compare
github-actions
bot
force-pushed
the
main
branch
from
6cd7c1b to
fb962c3
Compare
This was referenced Nov 11, 2025
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This will break snapit usage for teams that are pointing snapit to the
mainbranch. Ensure this grokt and world search are fixed before shipping.comment_commandtrigger_commentcustom_message_prefixcomment_prefixcustom_message_suffixcomment_suffixgithub_comment_included_packagescomment_packagesglobal_installcomment_is_globalworking_directorycwdbranchbranchpost_install_scriptpost_install_scriptbuild_scriptbuild_script