Make --output-file flag dependent on --watch in bulk operations
#6691
+10
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Requires removing the default flag value for `--watch`
nickwesselman
changed the title
app bulk execute should require --watch when using --output-file * Requires removing the default flag value for --watchoutput-file flag depend on watch and update descriptions
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
nickwesselman
changed the title
output-file flag depend on watch and update descriptions--output-file flag dependent on --watch in bulk operations
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
Contributor
Author
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3484 tests passing in 1406 suites. Report generated by 🧪jest coverage report action from 31337c0 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes an issue where the
output-fileflag could be used without thewatchflag, which would result in unexpected behavior since the output file is only written when watching for bulk operation results.WHAT is this pull request doing?
output-fileflag dependent on thewatchflag, ensuring it can only be used when watching for resultswatchflag to clarify that it defaults to falsewatchflag and instead handles the default in the command executionHow to test your changes?
--output-filewithout specifying--watchand verify that an error is shown--watchand--output-fileand verify that results are written to the specified filewatchflagMeasuring impact
How do we know this change was effective? Please choose one:
Checklist