-
Notifications
You must be signed in to change notification settings - Fork 219
wip #6660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
wip #6660
Conversation
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/themes/utils.d.ts@@ -6,4 +6,5 @@ export type Role = typeof DEVELOPMENT_THEME_ROLE | typeof LIVE_THEME_ROLE | type
export declare function isDevelopmentTheme(theme: Theme): boolean;
export declare function promptThemeName(message: string): Promise<string>;
export declare function composeThemeGid(id: number): string;
-export declare function parseGid(gid: string): number;
\ No newline at end of file
+export declare function parseGid(gid: string): number;
+export declare function filePathToFileUrl(filePath: string): string;
\ No newline at end of file
|
|
/snapit |
|
🫰✨ Thanks @EvilGenius13! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20251124172333Caution After installing, validate the version by running just |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3376 tests passing in 1383 suites. Report generated by 🧪jest coverage report action from ab1c66a |
ab1c66a to
32e91fe
Compare
|
/snapit |
|
🫰✨ Thanks @EvilGenius13! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20251124205221Caution After installing, validate the version by running just |
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist