Allow non-interactive app init
#6640
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
nickwesselman
changed the title
app initapp init
Contributor
Author
|
Will need to figure out why unit tests are failing. Works on my machine ™️. |
Contributor
|
/snapit |
Contributor
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20251120104339Caution After installing, validate the version by running just |
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3372 tests passing in 1382 suites. Report generated by 🧪jest coverage report action from 37f0070 |
nickwesselman
force-pushed
the
allow_noninteractive_app_init
branch
from
250ba03 to
94b8275
Compare
nickwesselman
changed the base branch from
graphite-base/6640
to
block-partners-for-3p
5 tasks
Contributor
Author
|
Converted PR to Draft to avoid merging before required server-side changes. |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/environment.d.ts@@ -53,7 +53,7 @@ export declare function jsonOutputEnabled(environment?: NodeJS.ProcessEnv): bool
/**
* If true, the CLI should not use the Partners API.
*
- * @returns True if the SHOPIFY_CLI_NEVER_USE_PARTNERS_API environment variable is set.
+ * @returns True when SHOPIFY_CLI_NEVER_USE_PARTNERS_API is set or SHOPIFY_CLI_1P_DEV is not set.
*/
export declare function blockPartnersAccess(): boolean;
/**
|
nickwesselman
force-pushed
the
allow_noninteractive_app_init
branch
from
94b8275 to
37f0070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The
app initcommand has interactive prompts that are impossible to bypass. This prevents scripting and some agentic use.(Agentic use may still be difficult as the agent needs to obtain the organization ID, but this puts us a step closer.)
WHAT is this pull request doing?
organization-idflag to suppress organization selectionnameflag suppresses interactive linking and name promptsinitcommandSHOPIFY_FLAG_CLIENT_IDenvironment definition in our GitHub actions to the acceptance test job specifically (where it's needed), since it was breaking the newapp inittestsHow to test your changes?
The following commands should all be successful:
The following should fail:
Measuring impact
How do we know this change was effective? Please choose one:
Checklist