Skip to content

Conversation

@JKipers
Copy link

@JKipers JKipers commented Nov 23, 2024

Just added boats to the vehicle_respawn_info.hpp so mission makers can place them in spawner in the future.

Added the boats to the subconfig vehicle_respawn_info.hpp. This allows for them to be added to spawners placed by mission makers on the map.
Ignore changes to .gitignore.
Copy link
Contributor

@dijksterhuis dijksterhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested, all works beautifully.

A few minor naming convention things, happy to merge it, but would be good to get these suggestions added to clean it up.


class boat_small {
name = "Small Boats";
RESPAWN_SHORT;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PBRs have more firepower than the STAB rigs, so might make more sense to default them to a longer respawn time?

Suggested change
RESPAWN_SHORT;
RESPAWN_LONG;

Comment on lines +1023 to +1024
class boat_small {
name = "Small Boats";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all PBRs, so might make a bit more sense to have it like this

Suggested change
class boat_small {
name = "Small Boats";
class boat_pbr {
name = "Boats - PBR";

Comment on lines +1005 to +1006
class boat_large {
name = "Large Boats";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all nasty boats, so might make a bit more sense to have it like this

Suggested change
class boat_large {
name = "Large Boats";
class boat_nasty {
name = "Boats - Nasty";

Comment on lines +982 to +983
class boat_light {
name = "Light Boats";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all STAB boats, so might make a bit more sense to have it like this

Suggested change
class boat_light {
name = "Light Boats";
class boat_stab {
name = "Boats - STAB";

RESPAWN_SHORT;

class categories {
class small_transport {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming convention

Suggested change
class small_transport {
class pbr_m60 {

WRECK_LONG;

class categories {
class large_boat_40mm {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming convention

Suggested change
class large_boat_40mm {
class nasty_40mm {

RESPAWN_MEDIUM;

class categories {
class light_transport_m2 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming convention

Suggested change
class light_transport_m2 {
class stab_m2 {

icon = VEHICLE_ICON_BOAT;
include[] = { { "light", "boat", "m2" } };
};
class light_transport_m60 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming convention

Suggested change
class light_transport_m60 {
class stab_m60 {

icon = VEHICLE_ICON_BOAT;
include[] = { { "light", "boat", "m60" } };
};
class light_transport_mk18 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming convention

Suggested change
class light_transport_mk18 {
class stab_mk18 {

Comment on lines +538 to +544







Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of empty space

Suggested change

@dijksterhuis dijksterhuis changed the title Boat branch : Added boat spawner entries for downstream mission editing Add boat spawner entries for downstream mission editing Dec 16, 2024
@dijksterhuis dijksterhuis added the priority merge Priority to be reviewed and merged label May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority merge Priority to be reviewed and merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants