Fix multiple listeners on command:beforeCommand event not stopping dispatch#4
Open
ChristopheMayet wants to merge 1 commit intoSachaMorard:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Sacha,
I found a bug in the execution of events in this line of Script class.
Here the
$this->_eventsManager->fire('command:beforeCommand', $command)call will return true (the last listener call) and then will not stop the command execution if multiple instance listn to this same event.To reproduce :
commandbeforeCommandmethod on bothfalseon the first listener (with higher priority)truefor the second listenerThe execution is not stopped while one of listener returned false.
This PR adresses this issue.