Add Param List UI element #247
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barulicm
reviewed
Jun 16, 2024
|
|
||
| // Expected format is: "/kenobi_node:stp_parameters.PlayName.ParamName" | ||
| const play_name = substrings[1]; | ||
| const stp_param_name = substrings[2]; |
Contributor
There was a problem hiding this comment.
This appears to assume all parameters are at the play level. Parameters can be created anywhere in the STP tree, so in reality we might have something like this: stp_parameters.StopPlay.EasyMoveTo.MaxVelocity.
How hard would it be to show that full tree?
barulicm
approved these changes
Jul 3, 2024
Contributor
barulicm
left a comment
barulicm
left a comment
There was a problem hiding this comment.
There's been a lot of offline conversations about parameters and how they should work in the future. We'll deal with the details of what this feature should become when we've figured out how parameters should work on the Kenobi side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When first opening the param list give it 3 seconds to fetch the params from ROS. If it still hasn't populated the values or you want to refetch the values use the refresh button at the top of the panel.