Parallel advection, Reconstruction and Regularization #79

dhyan1272 · 2025-07-01T04:53:36Z

Parallel advection, Reconstruction and Regularization

… regularization

…l interpolation of velocity increment, setget method of velocity increment with Timers

…performance

onkarsahni

Looks good overall. A few changes needed.

src/pmpo_MPMesh.cpp

src/pmpo_c.cpp

src/pmpo_materialPoints.hpp

src/pmpo_utils.hpp

src/pmpo_wachspressBasis.hpp

dhyan1272 · 2025-08-12T22:05:00Z

I have made the changes, Please let me know of any issues.

onkarsahni

A few more changes needed.
Sometimes indentation is off, e.g., check this link on a web browser:

polyMPO/src/pmpo_c.cpp

Lines 200 to 206 in 3545660

    
           void polympo_startRebuildMPs2_f(MPMesh_ptr p_mpmesh, 
        
                                    const int sizeMP2elm, 
        
           		         const int* elem_ids, 
        
           			 const int nMPs_delete, 
        
           			 const int nMPs_add, 
        
                                    int* recvMPs_elm, 
        
                                    int* recvMPs_ids) {

And also open a ticket/issue on making order of routines/functions consistent between these 3 files: pmpo_fortran.f90, pmpo_c.h, and pmpo_c.cpp

Issue #81

src/pmpo_MPMesh_assembly.hpp

src/pmpo_c.cpp

src/pmpo_c.h

src/pmpo_wachspressBasis.hpp

src/pmpo_utils.hpp

dhyan1272 · 2025-08-13T22:48:35Z

Changes have been committed, Please review

onkarsahni

A few more changes needed.

src/pmpo_c.h

src/pmpo_MPMesh_assembly.hpp

dhyan1272 · 2025-08-14T17:47:21Z

Changes committed, Please let me know of issues.

onkarsahni

Looks good.

onkarsahni · 2025-08-15T01:37:30Z

Approved, squashed, merged and deleted branch.

dhyan1272 added 26 commits January 9, 2025 10:08

New Regualization method with dual cell triangle involved

c1d22b0

Scaling and regularization

eb482e8

Tests read the areaTriangle field, so tests should be successful with…

bc6d278

… regularization

Dellaocation, removed log file and created paper folder

f8d54fc

Order 1 reconstruction, coefficients calculated once

5da1001

Multi process debugging

a591f11

More debugging

7be04f9

Added global ids to polyMPO from MPAS

fefd5e5

Running on multiple processors

8bc0780

Vtp files issue for multi-process

e004bc5

Towards multi Process

4274cd6

One more way of trying MPAS AppIDs

537b355

MPASAppID now takes cell no as input

c52bfa7

iParticleNew Issue

8e310cf

New particleID can be found from MPAS in polyMPO

aeb3e65

Before Phase 1

a8582e8

Push operation from MPAS in while loop

3988a6a

Woking 2 proc case

77cde5b

Removed print annd some cleaning

a9e74ab

Some more redudancy removed like trying to get new AppID from MPAS

607de99

All tests on remus pass

4b6930f

Removed print statement

00643ff

Parallel-reconstruction using MPAS

14b0c74

MaxAppID commentted out for multiple Proc

8ef0501

Parallel Reconstruction Templated

10f27c5

Some more clean up

d4ac97a

dhyan1272 requested review from Angelyr, cwsmith and onkarsahni as code owners July 1, 2025 04:53

Velocity Increment Interpolation and updating velocity in advection

b439df6

dhyan1272 added 7 commits July 11, 2025 09:48

Standard physics qualitative comparison, Kokkos fence before spherica…

f89a03f

…l interpolation of velocity increment, setget method of velocity increment with Timers

Timings fixed/added

d89991e

Avoid calculating basis twice for 2 fields, this version in USNCCM18 …

380ac70

…performance

Updated timers get set in reconstruction

91d4185

Couple of more timers

a786bc1

Some more cleaning

01d4525

elm2Process needed for ctest

9507b84

onkarsahni requested changes Aug 12, 2025

View reviewed changes

dhyan1272 added 4 commits August 12, 2025 17:43

RP changes1_v0

14519cf

RP changes1_v1

e5b2a1a

RP changes1_v2

7f362c0

RP changes1_v3

3545660

onkarsahni requested changes Aug 13, 2025

View reviewed changes

PR changes2_v0

775ca49

dhyan1272 added 2 commits August 13, 2025 18:53

PR changes2_v1

4839c60

PR changes2_v2

8a92ee9

onkarsahni requested changes Aug 14, 2025

View reviewed changes

src/pmpo_c.h Show resolved Hide resolved

src/pmpo_MPMesh_assembly.hpp Outdated Show resolved Hide resolved

PR changes3_v0

fe85441

onkarsahni approved these changes Aug 15, 2025

View reviewed changes

onkarsahni merged commit 252b2f7 into cws/pumipicDps Aug 15, 2025
1 check passed

onkarsahni deleted the dn/multi-gpu-rec branch August 15, 2025 01:37

	void polympo_startRebuildMPs2_f(MPMesh_ptr p_mpmesh,
	const int sizeMP2elm,
	const int* elem_ids,
	const int nMPs_delete,
	const int nMPs_add,
	int* recvMPs_elm,
	int* recvMPs_ids) {

Parallel advection, Reconstruction and Regularization #79

Parallel advection, Reconstruction and Regularization #79

Uh oh!

Conversation

dhyan1272 commented Jul 1, 2025

Uh oh!

onkarsahni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dhyan1272 commented Aug 12, 2025

Uh oh!

onkarsahni left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dhyan1272 commented Aug 13, 2025

Uh oh!

onkarsahni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dhyan1272 commented Aug 14, 2025

Uh oh!

onkarsahni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

onkarsahni commented Aug 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

onkarsahni left a comment •

edited

Loading