Retry in case of 409 conflict error #359
Open
+111
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a rate-limited retry for 409 (Conflict) errors coming from the K8s API.
That is: if Kubernetes' optimistic update/patch/delete locking (based on
metadata.resourceVersion) fails, a 409 (Conflict) error is returned to the client. This is not a severe problems (because the controller will anyway requeue, and the next turn probably will run through). But it causes noise in the logs, and flickering conditions and statuses.With this PR, one non-error retry (after one second) is permitted per object per minute. That is, if an object experiences a 409 error for an update/patch/delete operation, and if it had none in the last minute, then the error is internally converted to a
RetriableError, and the object gets requeued after one second.