Refactor client handling #358
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two purposes:
First, a step towards the standard 'errors' package is made. That is, any references to
utilerrors.NewAggregate()andmultierror.Append()are replaced byerrors.Join(). Note that errors produced byerrors.Join()support botherrors.Is()anderrors.As().Furthermore, all imports of the deprecated 'github.com/pkg/errors' package are aliased as 'legacyerrors'. The only remaining usage of 'legacyerrors' should be
legacyerrors.Wrap()andlegacyerrors.Wrapf(). In a later phase, we will replace these byfmt.Errorf()with%w.Second, the K8s client handling in
component.Reconcile()is revisited. That is, instead of using the manager's client (i.e.mgr.GetClient()) for the component reconciler (that is the client interacting with the component resources), we construct a dedicated client frommgr.GetConfig()andmgr.GetScheme(). Notes:component.Reference[T]still use the manager's client.