spirv-builder: when no artifact is produced, error instead of panic #496
+5
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some cargo commands like clippy won't produce artifacts, so we want to ignore that error in cargo-gpu
Firestar99
force-pushed
the
no_artifacts
branch
from
82c6787 to
86d74b6
Compare
This was referenced Dec 22, 2025
LegNeato
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cargo commands like clippy won't produce artifacts, so we want to ignore that error in cargo-gpu. But spirv-builder immediately panics, instead of returning a nice
SpirvBuilderErrorthat cargo-gpu can special case.cargo gpu clippycargo-gpu#131