Closed
Conversation
Collaborator
|
Should this be a part of the changes summarized at #44 (comment) ? |
Collaborator
|
@jeswr is this something you're still working on? Would this be releasable as 3.x or 4.x? |
Collaborator
Author
|
@jacoscaz The changes are still valid - and there are no breaking changes. I can try and work on the test coverage over the weekend depending on my time (though I'm looking a bit stretched thin at this point). |
Collaborator
|
No pressure or rush meant! Just checking, I was having a look at updating my summary in #44 and wasn't sure about this one. Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #75 (comment).
TODOs
AsyncIterator/asynciterator.ts
Lines 905 to 911 in 3a5b62c
rootis.readableif the parent source is.readable. If we assume that all of the intermediary sources areSynchronousTransformIterators as is the case when doing chaining then this will be true; but I am not sure if we should be making this assumption.Quick testing indicates that this results in a ~2x performance increase on the tests in #75