Skip to content

Customizable GUI#328

Draft
RoinujNosde wants to merge 17 commits intomasterfrom
customizable-gui
Draft

Customizable GUI#328
RoinujNosde wants to merge 17 commits intomasterfrom
customizable-gui

Conversation

@RoinujNosde
Copy link
Owner

@RoinujNosde RoinujNosde commented Aug 24, 2022

Example config:

rows: 3
components:
  leaderboard:
    slot: 3
    material: PAINTING
    enabled: true
  decorations:
    panels:
      slots: [0, 1, 2, 3, 4, 5, 6, 7, 8]
      material: GRAY_STAINED_GLASS_PANE
      enabled: true

To do:

  • Enable/disable components
  • Decorator components instead of panels?
  • Update XMaterial
  • Test config path for custom frames
  • Fix Exception if default components are not in the config
  • PostComponentsCreationEvent
  • Custom heads?

@RoinujNosde RoinujNosde added the enhancement New feature or request label Aug 24, 2022
@RoinujNosde RoinujNosde requested a review from Tomut0 December 21, 2022 01:05
RoinujNosde and others added 4 commits December 25, 2022 17:44
# Conflicts:
#	SimpleClans.iml
#	dependency-reduced-pom.xml
#	pom.xml
#	src/main/java/net/sacredlabyrinth/phaed/simpleclans/managers/SettingsManager.java
#	src/main/java/net/sacredlabyrinth/phaed/simpleclans/ui/SCFrame.java
@RoinujNosde RoinujNosde requested a review from Tomut0 March 9, 2025 19:50
this.item = item;
}

public Builder(FileConfiguration config, String id) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps, a enum instead of id?
or separated constructor with enum

if (decorSection != null) {
for (String key : decorSection.getKeys(false)) {
addAll(new SCComponentImpl.ListBuilder<>(getConfig(), "decorations." + key)
.withDisplayNameKey(" ").build());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know some people would like to place some text in decorations.

@TheRealStone
Copy link

Keep going with this excellent job!

@Nishikiyama
Copy link
Contributor

Keep going with this excellent job!

Nuh uh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants