Draft
Conversation
2c0e6b1 to
6a570cf
Compare
src/main/java/net/sacredlabyrinth/phaed/simpleclans/ui/SCFrame.java
Outdated
Show resolved
Hide resolved
RoinujNosde
commented
Dec 12, 2022
src/main/java/net/sacredlabyrinth/phaed/simpleclans/utils/Paginator.java
Outdated
Show resolved
Hide resolved
src/main/java/net/sacredlabyrinth/phaed/simpleclans/ui/SCFrame.java
Outdated
Show resolved
Hide resolved
Tomut0
requested changes
Dec 21, 2022
src/main/java/net/sacredlabyrinth/phaed/simpleclans/managers/SettingsManager.java
Show resolved
Hide resolved
src/main/java/net/sacredlabyrinth/phaed/simpleclans/ui/SCComponentImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/sacredlabyrinth/phaed/simpleclans/ui/PageableFrame.java
Outdated
Show resolved
Hide resolved
src/main/java/net/sacredlabyrinth/phaed/simpleclans/ui/SCComponentImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/sacredlabyrinth/phaed/simpleclans/ui/SCComponentImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/sacredlabyrinth/phaed/simpleclans/ui/SCComponentImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/sacredlabyrinth/phaed/simpleclans/managers/SettingsManager.java
Show resolved
Hide resolved
# Conflicts: # SimpleClans.iml # dependency-reduced-pom.xml # pom.xml # src/main/java/net/sacredlabyrinth/phaed/simpleclans/managers/SettingsManager.java # src/main/java/net/sacredlabyrinth/phaed/simpleclans/ui/SCFrame.java
Tomut0
requested changes
Mar 9, 2025
src/main/java/net/sacredlabyrinth/phaed/simpleclans/ui/SCComponentImpl.java
Show resolved
Hide resolved
src/main/java/net/sacredlabyrinth/phaed/simpleclans/ui/SCFrame.java
Outdated
Show resolved
Hide resolved
| this.item = item; | ||
| } | ||
|
|
||
| public Builder(FileConfiguration config, String id) { |
Collaborator
There was a problem hiding this comment.
perhaps, a enum instead of id?
or separated constructor with enum
src/main/java/net/sacredlabyrinth/phaed/simpleclans/ui/PageableFrame.java
Show resolved
Hide resolved
src/main/java/net/sacredlabyrinth/phaed/simpleclans/ui/PageableFrame.java
Show resolved
Hide resolved
src/main/java/net/sacredlabyrinth/phaed/simpleclans/ui/SCComponentImpl.java
Show resolved
Hide resolved
| if (decorSection != null) { | ||
| for (String key : decorSection.getKeys(false)) { | ||
| addAll(new SCComponentImpl.ListBuilder<>(getConfig(), "decorations." + key) | ||
| .withDisplayNameKey(" ").build()); |
Collaborator
There was a problem hiding this comment.
I know some people would like to place some text in decorations.
src/main/java/net/sacredlabyrinth/phaed/simpleclans/ui/PageableFrame.java
Show resolved
Hide resolved
|
Keep going with this excellent job! |
Contributor
Nuh uh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example config:
To do: