feat: initial obs implementation #732
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejmajek
force-pushed
the
feat/obs
branch
from
151c07e to
46eb283
Compare
maciejmajek
force-pushed
the
feat/obs
branch
from
46eb283 to
9f1f774
Compare
Collaborator
|
Since this is a WIP, I am holding off the review. A few reference implementations to illustrate the ideas given to your RFC: obs context, life cycle + heartbeat, here&here. |
Juliaj
reviewed
Dec 17, 2025
| fn = getattr(cls, method_name, None) | ||
| handler = handler_map.get(method_name) | ||
| if not fn or not handler: | ||
| continue |
Collaborator
There was a problem hiding this comment.
When running unit test, this caused one of the tests to fail with timeout. This in turn revealed an issue of double-wrapping inherited methods. This can happen when a base class is created with this metaclass and a subclass is created with the same metaclass. See more details at here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
#733
Proposed Changes
#733
Issues
#733
Testing