Skip to content

Conversation

@bradhanks
Copy link
Collaborator

Refactors the block-related modules by consolidating them into a single file (block.ex) and introduces type definitions for EarmarkParser.Block.t and EarmarkParser.Link.t. The goal is to improve code organization, maintainability, and type safety.

Related Issue: #166

Changes:

  1. Removed the block folder and all associated module files.

  2. Created lib/earmark_parser/block.ex to house the consolidated module.

  3. Consolidated all child modules into a single file.

  4. Added type definition for EarmarkParser.Block.t.

  5. Added type definition for EarmarkParser.Link.t.

Benefits:

  • Improved code organization and maintainability.
  • Enhanced type safety and clarity through type definitions (want to be able to add specification with Block.t which wasn't currently possible)
  • Simplified file structure for easier navigation and future development.

@bradhanks
Copy link
Collaborator Author

mix test worked for me:

50 doctests, 1005 tests, 0 failures, 5 excluded, 1 skipped

@RobertDober RobertDober merged commit 1a82188 into RobertDober:master Mar 18, 2025
7 checks passed
@bradhanks bradhanks deleted the block_edits branch March 18, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants