Skip to content

Conversation

@Banane9
Copy link
Contributor

@Banane9 Banane9 commented Jan 11, 2025

@Banane9 Banane9 requested a review from Nytra January 11, 2025 20:54
@Nytra
Copy link
Contributor

Nytra commented Jan 12, 2025

How is this different from the original? The only part I can see that is different is var audioTypeGroup = await UniversalImporter.DetectAudioTypeGroup(audioPlayerInterface.Clip.Target.Target); which wouldn't change much I think

@Banane9 Banane9 merged commit dde5bb0 into master Jan 12, 2025
2 checks passed
@Banane9 Banane9 deleted the fix/failing-import-multiple-audios branch January 12, 2025 01:37
@Banane9
Copy link
Contributor Author

Banane9 commented Jan 12, 2025

Oops, just saw approved in the emails and thought it was both :'D

The difference is that audioPlayerInterface.Clip.Target.Target actually has the clip, while the slot.GetComponentInChildren<IAssetProvider>() in the original doesn't work.
I'm not exactly sure why, but I tested it not working before and working after the change.

@Nytra
Copy link
Contributor

Nytra commented Jan 12, 2025

Oh it's because SpawnEntity does not specify an assets slot, so they go to the world assets slot instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants