Windows: improve dependency lookup when loading module library.#179
Open
bruvzg wants to merge 1 commit intoRenderKit:masterfrom
Open
Windows: improve dependency lookup when loading module library.#179bruvzg wants to merge 1 commit intoRenderKit:masterfrom
bruvzg wants to merge 1 commit intoRenderKit:masterfrom
Conversation
This was referenced Oct 14, 2023
|
Bump 🙂 Any interest in reviewing this? This would make it possible for Godot to use OIDN as a library, as opposed to calling its |
Collaborator
|
Sorry, there is interest but so far we had other priorities. We need to look into this carefully because it might have some security implications as well. |
Contributor
|
@bruvzg - Could you provide specific details about the problem you're addressing? It would be helpful if you could show the exact location of the DLLs mentioned in the description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes loading of the module library dependencies when OIDN main library is dynamically loaded at runtime, and libraries are not in the executable directory.
e.g., when app dynamically load
OpenImageDenoise.dllat runtime, using absolute path, ModuleLoader attempts to loadOpenImageDenoise_device_cpu.dllmodule, but it fails sincetbb12.dllis not in the library search path. This change temporary adds the module library directory to the search path to ensure dependencies are loaded correctly.