Fixing verify / Fixing EMBREE_RAY_PACKETS=OFF#275
Open
maikschulze wants to merge 4 commits intoRenderKit:masterfrom
Open
Fixing verify / Fixing EMBREE_RAY_PACKETS=OFF#275maikschulze wants to merge 4 commits intoRenderKit:masterfrom
maikschulze wants to merge 4 commits intoRenderKit:masterfrom
Conversation
To test this, run 'verify' with the arguments '--run .*SSE2.update.* --sequential'
maikschulze
changed the title
… filter out the computed hits in the epilog function. Note that RTC_DEVICE_PROPERTY_BACKFACE_CULLING_ENABLED is not fully functional and appears to be always disabled in the intersector. Hence, the test will still fail when compiling with RTC_DEVICE_PROPERTY_BACKFACE_CULLING_ENABLED=OFF (reporting 4 instead of 2 hits)
…' information on rtcOccluded. This information is only written on rtcIntersect. We blindly pass these cases.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Syoyo and I have noticed that the 'verify' executable creates various FAILED results, particularly when compiling with EMBREE_RAY_PACKETS=OFF
We provide a fix to the rtcIntersect4/8/16 and rtcOccluded4/8/16 functions for the rare case '!defined(EMBREE_RAY_PACKETS)'. This fixes invalid casts between RTCRayK/RTCRayHitK and RayK and RayHitK and ensures that proper set/get functions are applied for the internal emulation through Ray and RayHit.
In addition, we partially fix the cause for failure of the 'RayMasksTest' case.
Without Pull Request (with EMBREE_RAY_PACKETS=OFF):
verify_sse2_before.txt
With Pull Request (with EMBREE_RAY_PACKETS=OFF):
verify_sse2_after.txt