add codetools for vignettes #7542
Conversation
ben-schwen
force-pushed
the
CI_codetools
branch
from
3008de7 to
1a2ace3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7542 +/- ##
=======================================
Coverage 98.97% 98.97%
=======================================
Files 87 87
Lines 16733 16733
=======================================
Hits 16561 16561
Misses 172 172 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
No obvious timing issues in HEAD=CI_codetools Generated via commit 0395e83 Download link for the artifact containing the test results: ↓ atime-results.zip
|
|
Is the change of gitlab.io urls to lowercase required? Why? |
pkgdown gave me a warning about one of them and right now we use both, so a bit of consistency seemed right. |
| 16. `merge.data.table` will raise warning if any of data.tables to join has 0 columns. Closes [#597](https://github.com/Rdatatable/data.table/issues/597). | ||
|
|
||
| 17. Travis-CI will now automatically deploy package to drat repository hosted on [data.table@gh-pages](https://github.com/Rdatatable/data.table/tree/gh-pages) branch allowing to install latest devel from **source** via `install.packages("data.table", repos = "https://Rdatatable.github.io/data.table", type = "source")`. Closes [#1505](https://github.com/Rdatatable/data.table/issues/1505). | ||
| 17. Travis-CI will now automatically deploy package to drat repository hosted on [data.table@gh-pages](https://github.com/Rdatatable/data.table/tree/gh-pages) branch allowing to install latest devel from **source** via `install.packages("data.table", repos = "https://rdatatable.github.io/data.table", type = "source")`. Closes [#1505](https://github.com/Rdatatable/data.table/issues/1505). |
There was a problem hiding this comment.
this one is github; we still use Rdatatable for github in a few other places.
(generally I might put this change separately, AFAICT there is only the tiny , codetools diff that matters in this PR... might be a good place for jj stacking)
3 participants
As shown by CI our images need
codetoolsto build vignettes. Successful run withcodetoolsis hereWe could also add it to the docker images but it feels more right to do it here.